! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Firefox crash upon exit
Status:
RESOLVED: INVALID
Product:
Gtk-xfce-engine
Component:
General

Comments

Description Vishnu 2016-02-25 15:12:45 CET
I am not very sure if this is an XFCE bug, but I think so, because I can not reproduce it on my GNOME and KDE desktops. Also, I am not sure if this bug should be under the Gtk-xfce-engine or xfwm4. I'm sorry if the category or the bug itself is inappropriate.

XFCE Version 4.12, distributed by Arch Linux

Every time I close firefox using the (x) at the top of the window, firefox does not close properly. I know this because when I start it the next time, firefox tell me that it closed improperly, and gives me the option to restore my previously open tabs.

When I close firefox using the 'Quit Firefox' button in the drop-down menu, it exits properly.

There is a slight noticeable difference in the time taken for firefox to close using the two methods. The former exits immediately, while the latter takes about a second or two.

Could it be that the cross (x) sends a bad kill signal?
Comment 1 Olivier Fourdan editbugs 2016-02-25 15:21:05 CET
(In reply to Vishnu from comment #0)
> Could it be that the cross (x) sends a bad kill signal?

The close button sends a client message WM_DELETE_WINDOW if the application supports it or kills the connection otherwise.

Do an "xprop" on the window see if WM_PROTOCOLS lists WM_DELETE_WINDOW, if that's the case then xfwm4 will use a WM_DELETE_WINDOW message.

All this is very standard and hasn't changed in years, so I really doubt xfwm4 has any bug there.
Comment 2 Vishnu 2016-02-25 18:09:06 CET
(In reply to Olivier Fourdan from comment #1)
> Do an "xprop" on the window see if WM_PROTOCOLS lists WM_DELETE_WINDOW, if
> that's the case then xfwm4 will use a WM_DELETE_WINDOW message.

Looks like it does:

WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
WM_CLASS(STRING) = "Navigator", "Firefox"

If this is not an XFCE bug, then what is it?
Comment 3 Olivier Fourdan editbugs 2016-02-25 18:20:12 CET
(In reply to Vishnu from comment #2)
> WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS,
> _NET_WM_PING, _NET_WM_SYNC_REQUEST
> 
> If this is not an XFCE bug, then what is it?

Can't tell, you'd need to investigate further...

 - Do you run FF from a terminal, what do you see?
 - If you have a multiple tabs, do you see the dialog from FF asking "You are about to close 8 tabs. Are you sure you want to continue?"
 - If you attach gdb to the running FF process and close the window, do you see a crash?
Comment 4 Olivier Fourdan editbugs 2016-02-25 18:24:22 CET
Note, "firefox" is usually a shell script, on Fedora (not sure about others) it accepts the option "-g" to run firefox directly from gdb, that could be helpful.
Comment 5 Vishnu 2016-02-29 21:40:42 CET
Looks like it is a firefox issue. A corrupt sessionstore cache.

Should I delete this bug report? Or will it go away some other way?
Comment 6 Olivier Fourdan editbugs 2016-03-01 08:27:47 CET
(In reply to Vishnu from comment #5)
> Looks like it is a firefox issue. A corrupt sessionstore cache.
> 
> Should I delete this bug report? Or will it go away some other way?

Nope, we'd need to close as invalid, bugs don't go away by themselves :)

Bug #12468

Reported by:
Vishnu
Reported on: 2016-02-25
Last modified on: 2016-03-01

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information