! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Fix potential buffer overflow
Status:
RESOLVED: FIXED

Comments

Description Mikhail Efremov 2016-02-11 17:18:37 CET
Created attachment 6608 
0001-Fix-potential-buffer-overflow.patch

Use g_malloc_n() instead of g_malloc to avoid integer overflow.
This fixes CVE-2013-7447, see http://www.openwall.com/lists/oss-security/2016/02/10/2 for details.
Comment 1 Git Bot editbugs 2018-01-28 23:18:14 CET
Mikhail Efremov referenced this bugreport in commit 7578cc83223b312af9900a08d9abe33df59a6c1b

Fix potential buffer overflow (bug #12444)

https://git.xfce.org/xfce/thunar/commit?id=7578cc83223b312af9900a08d9abe33df59a6c1b
Comment 2 Git Bot editbugs 2018-01-28 23:20:13 CET
Alexander Schwinn referenced this bugreport in commit 57e78a363ccab345c5bf90a43fc8f9c8d60e3a92

Fix potential buffer overflow (bug #12444) reverted - sorry, thought I tested, but I did not :F

https://git.xfce.org/xfce/thunar/commit?id=57e78a363ccab345c5bf90a43fc8f9c8d60e3a92
Comment 3 alexxcons editbugs 2018-01-28 23:21:39 CET
Sorry for late reply !

Gna, sorry ... I should take better care.
Need to add extra argument for "g_malloc_n"
Comment 4 Git Bot editbugs 2018-01-28 23:23:56 CET
Mikhail Efremov referenced this bugreport in commit ca3571e0f7ff1781a085106d58837bb01f994659

Fix potential buffer overflow (bug #12444)

https://git.xfce.org/xfce/thunar/commit?id=ca3571e0f7ff1781a085106d58837bb01f994659
Comment 5 alexxcons editbugs 2018-01-28 23:25:20 CET
ok, this time :F

Thanks for the patch !
Comment 6 Git Bot editbugs 2018-01-29 09:56:43 CET
Mikhail Efremov referenced this bugreport in commit 6d8b604cad217884d884a641bf7c2e19b7ca36f8

Fix potential buffer overflow (Bug #12444)

https://git.xfce.org/xfce/thunar/commit?id=6d8b604cad217884d884a641bf7c2e19b7ca36f8
Comment 7 alexxcons editbugs 2018-01-29 09:58:55 CET
^^ as well fixed for xfce 4.12 branch

Bug #12444

Reported by:
Mikhail Efremov
Reported on: 2016-02-11
Last modified on: 2018-01-29

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
unspecified

Attachments

0001-Fix-potential-buffer-overflow.patch (1.13 KB, patch)
2016-02-11 17:18 CET , Mikhail Efremov
no flags

Additional information