! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop crashes if there is no menu file available and user wants to see th...
Status:
CLOSED: FIXED
Severity:
critical
Product:
Xfdesktop
Component:
General

Comments

Description tkoskine 2004-02-24 18:50:52 CET
xfdesktop crashes if there is no menu file available
and create_desktop_menu() function is called twice.

The source code location: xfdesktop-4.0.3/src/menu.c
/* returns the menu widget */
static GtkWidget *create_desktop_menu(void)
{
...
/* Still no luck? Something got broken! */
if (stat(filename, &st) < 0)
{
if (filename)
{
g_free(filename);
}
return NULL;
}
...
}
Comment 1 tkoskine 2004-02-24 18:50:54 CET
Additional information:

How to repeat:
On OpenBSD-current(Feb 2004):
# cd /usr/ports/x11/xfce4/desktop/xfdesktop
# make install
$ xfdesktop
Then right-click the desktop twice. (Yes, that xfdesktop
port is slightly broken.)

How to fix:
Add line
filename = NULL;
after g_free(filename).

$ diff -u menu.orig.c menu.c
--- menu.orig.c Tue Feb 24 20:36:56 2004
+++ menu.c Tue Feb 24 20:40:15 2004
@@ -498,6 +498,7 @@
if (filename)
{
g_free(filename);
+ filename = NULL;
}
return NULL;
}
Comment 2 Brian J. Tarricone (not reading bugmail) 2004-02-24 19:03:46 CET
fixed in CVS, both HEAD and xfce_4_0 branch. thanks for the report and fix!
Comment 3 Brian J. Tarricone (not reading bugmail) 2004-10-12 22:25:25 CEST
mass reassign from zz-do-not-use to general, so i can remove the zz-do-not-use
component.  sorry for the spam, search for this string to filter these:
fis7cldoq35p3kjdu74emc

Bug #124

Reported by:
tkoskine
Reported on: 2004-02-24
Last modified on: 2009-07-15

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Attachments

Additional information