! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Terminal link detection improperly detects non-link text regions
Status:
RESOLVED: MOVED
Product:
Xfce4-terminal
Component:
General

Comments

Description Remy Goldschmidt 2016-01-02 11:00:41 CET
Created attachment 6573 
The bug (my mouse is over the underlined text, it just wasn't picked up by scrot)

Note: The bug tracker didn't give me an option for version 0.6.3 (the version I am running) so I put 0.6.2 as my version.

I am running xfce4-terminal on NixOS unstable (SVN revision: 73316.93d8671). NixOS builds xfce4-terminal from the source at [1]. NixOS doesn't use any flags in building xfce4-terminal; it just does `./configure --prefix=...; make; make install`.

To reproduce the bug, open xfce4-terminal and do the following:

  1. Run `echo "ftp.example"`
  2. Move your mouse pointer over the echoed text

The bug is that the string "ftp.example" is recognized as a link, even though it clearly isn't one.

The relevant code is in `<source-root>/terminal/terminal-widget.c` (linked at [2]).

Potential fixes:

  * Modify the link-detection code to use one of the regexes from [3] --- preferably one with better edge case handling.
  * Write a proper parser for links based on RFC 1738 [4] (this may be similarly buggy).

Links:

  * [1] --- <http://archive.xfce.org/src/apps/xfce4-terminal/0.6/xfce4-terminal-0.6.3.tar.bz2>
  * [2] --- <https://bazaar.launchpad.net/~vcs-imports/xfce4-terminal/trunk/view/head:/terminal/terminal-widget.c>
  * [3] --- <https://mathiasbynens.be/demo/url-regex>
  * [4] --- <https://www.ietf.org/rfc/rfc1738.txt>
Comment 1 Git Bot editbugs 2020-05-24 23:41:37 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-terminal/-/issues/12.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12386

Reported by:
Remy Goldschmidt
Reported on: 2016-01-02
Last modified on: 2020-05-24

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Attachments

Additional information