! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Improper rounding of DPI value
Status:
RESOLVED: MOVED
Product:
Xfce4-settings
Component:
Xfsettingsd

Comments

Description simon 2015-12-08 21:32:39 CET
There is a roudning error when calculating the dpi value for a screen.

In xsettings.c / xfce_xsettings_helper_screen_dpi() the calculation of width_dpi / height_dpi lacks rounding.

Tools like xdpyinfo use rounding for presenting the dpi value. In some corner cases this has the effect that "overriding" the dpi value within xfce-settings with the same value as reported by xdpyinfo results in changing font sizes.

      width_dpi =  (int) ((25.4 * WidthOfScreen  (xscreen)) / width_mm  + 0.5);
      height_dpi = (int) ((25.4 * HeightOfScreen (xscreen)) / height_mm + 0.5);
Comment 1 Git Bot editbugs 2020-05-28 23:04:12 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-settings/-/issues/71.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12353

Reported by:
simon
Reported on: 2015-12-08
Last modified on: 2020-05-28

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information