! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-display-settings crash in xfce_randr_preferred_mode at xfce-randr.c:632
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Display Settings

Comments

Description Kevin Fenzi 2015-12-06 23:46:58 CET
Downstream bug: 

https://bugzilla.redhat.com/show_bug.cgi?id=1288885

Full backtrace at the bug above. 

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 xfce_randr_preferred_mode at xfce-randr.c:632
 #1 convert_xfce_output_info at main.c:1601
 #2 list_connected_outputs at main.c:1786
 #3 on_area_paint at main.c:2589
 #8 foo_scroll_area_expose at scrollarea.c:522
 #9 _gtk_marshal_BOOLEAN__BOXED at gtkmarshalers.c:86
 #14 gtk_widget_event_internal at gtkwidget.c:5017
 #15 gtk_widget_send_expose at gtkwidget.c:4846
 #16 gtk_container_propagate_expose at gtkcontainer.c:2757
 #17 gtk_container_expose at gtkcontainer.c:2661
Comment 1 doldev 2016-09-29 00:45:02 CEST
Created attachment 6868 
Patch that solved divide by zero
Comment 2 doldev 2016-09-29 00:51:51 CEST
I experienced the same crash on the latest Ubuntu 16.04 version with xfce4-settings 4.12.

Investigating the crash information it looks like that return value of 'gdk_screen_height_mm ()' [ https://git.xfce.org/xfce/xfce4-settings/tree/dialogs/display-settings/xfce-randr.c#n632 ] is zero.
This leads to an divide by zero crash.

The patch will fix this issue. Not sure about the side effects of the patch.


Report from 'apport-retrace'
============================
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `xfce4-display-settings'.
Program terminated with signal SIGFPE, Arithmetic exception.
#0  0x0000556954790a44 in xfce_randr_preferred_mode (randr=<optimised out>, 
    output=<optimised out>) at xfce-randr.c:632
632	xfce-randr.c: No such file or directory.
[Current thread is 1 (Thread 0x7f70e7b6da40 (LWP 4205))]
(gdb)
Comment 3 Pim Pronk 2017-01-09 19:55:31 CET
Can confirm this issue, xfce4-display-settings exists with a Floating point exception.
Although this patch solves this issue, I wonder why randr->priv->modes[output][n].mm_height does return a value and gdk_screen_height_mm() does not? Is this patch enough or does it only fix a symptom of a deeper problem?
Comment 4 Miki Tebeka 2017-04-22 10:30:52 CEST
Any news on this one? I'm experiencing it as well.

Bug #12350

Reported by:
Kevin Fenzi
Reported on: 2015-12-06
Last modified on: 2020-05-28

People

Assignee:
Jérôme Guelfucci
CC List:
9 users

Version

Version:
4.12.0

Attachments

Additional information