! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Empty brightnes indicator
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Mukundan Ragavan 2015-11-07 16:34:19 CET
Created attachment 6522 
screenshot showing brightness indicator

When adjusting screen brightness using the keyboard, the brightness indicator shows up empy.

Just to be clear - brightness **DOES** change.


Only the indicator shows no scale/information.


The screenshot attached showing this behavior was taken under greybird theme. The same behavior seems to exist in other themes as well (so not a theme issue, I believe).
Comment 1 Laurentiu Pancescu 2015-12-11 11:26:37 CET
Created attachment 6556 
bug fix

The bug was introduced on 2015-03-22 in commit 9efe26ead5bb1e0f100c0d126b105d1ed2d5b131: the xfpm-* icons were removed in favor of the UPower icons, but xfpm_show_notification() still calls xfpm_notify_new_notification() with the old icon name "xfpm-display-brightness-lcd".  The notification box seems empty because xfce4-notifyd sets the width of the progress bar to 4 times the width of the icon (which cannot be found, probably 0 - see xfce4-notifyd/xfce-notify-window.c, in function xfce_notify_window_set_gauge_value).  The attached patch which should fix the issue.
Comment 2 Laurentiu Pancescu 2015-12-11 11:40:22 CET
Created attachment 6557 
patch fixing both icon names

I just went through the results of 'grep -rn xfpm- src/' in my local xfce4-power-manager repository.  There's another instance of trying to load a removed icon, in src/xfpm-kbd-backlight.c:117 ("xfpm-brightness-keyboard" should probably be changed to "keyboard-brightness").  I never saw that notification - is it only for backlit keyboards?  I now attached a patch containing both changes.
Comment 3 Mukundan Ragavan 2015-12-18 03:41:44 CET
patch in comment 2 fixes the issue for me!

Thanks Laurentiu!
Comment 4 Woi 2015-12-25 11:57:13 CET
This bug affects Fedora 23. See: https://bugzilla.redhat.com/show_bug.cgi?id=1278772
Comment 5 Simon Steinbeiss editbugs 2016-01-23 12:49:59 CET
Thanks for the patch and sorry for taking so long to review and merge it.

Pushed to master in http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=2ff69c8475cfb4b121ba107c41249a63aa8dffb2
Comment 6 Simon Steinbeiss editbugs 2016-01-24 16:20:47 CET
*** Bug 12302 has been marked as a duplicate of this bug. ***
Comment 7 Woi 2016-02-04 02:21:00 CET
Any plans for a release to push this bugfix downstream?
Comment 8 Woi 2016-02-04 02:21:26 CET
Sorry, I missed to add this link: https://bugzilla.redhat.com/show_bug.cgi?id=1278772#c8

Bug #12292

Reported by:
Mukundan Ragavan
Reported on: 2015-11-07
Last modified on: 2016-02-04
Duplicates (1):
  • 12302 Popup notification for keyboard brightness changes - squeezed

People

Assignee:
Ali Abdallah
CC List:
6 users

Version

Attachments

screenshot showing brightness indicator (1.63 KB, image/png)
2015-11-07 16:34 CET , Mukundan Ragavan
no flags
bug fix (359 bytes, patch)
2015-12-11 11:26 CET , Laurentiu Pancescu
no flags
patch fixing both icon names (773 bytes, patch)
2015-12-11 11:40 CET , Laurentiu Pancescu
no flags

Additional information