Comment 1 Theo Linkspfeifer 2019-05-03 14:12:24 CEST

*** Bug 13674 has been marked as a duplicate of this bug. ***

Comment 2 Andre Miranda 2019-05-14 02:08:34 CEST

Created attachment 8518 
updated patch

This option only works if "Change the background" is enabled, perhaps it should be wise to hide or disable its menu item accordingly.

Comment 3 Andre Miranda 2019-05-14 02:19:25 CEST

The backdrop-cycle-enable prop is not global, but per screen/monitor/workspace.
The prop string is generated by xfdesktop_settings_generate_per_workspace_binding_string, idk if it's easy/possible to get this info at xfdesktop_file_icon_manager_populate_context_menu.

Comment 4 Theo Linkspfeifer 2019-05-15 19:18:12 CEST

Created attachment 8527 
proposed patch

How about this?

Comment 5 Andre Miranda 2019-05-17 00:12:43 CEST

(In reply to Theo Linkspfeifer from comment #4)
> Created attachment 8527 
> proposed patch
> 
> How about this?

Doesn't work as expected:
1 - Backdrop cycle is disabled
2 - Enable backdrop cycle
3 - Right click on desktop, there is no menu item to change the backdrop
4 - Restart xfdesktop
5 - Right click on desktop, now the menu item is there
6 - Disable backdrop cycle
7 - Right click on desktop,  the menu item is still there
8 - Restart xfdesktop
9 - Right click on desktop, now the menu item is gone

Comment 6 Andre Miranda 2019-05-17 00:19:36 CEST

This can be accomplished with Thunar Custom Actions:
Name: Next background
Command: xfdesktop --next
Icon: Actions Icons -> go-next
File Pattern: Desktop
Appears if selection contains: Directories

The drawbacks are:
- xfdesktop has to be restarted
- This changes the background of all monitors with cycle enabled
- The action is shown regardless of if any monitor has cycle enabled

Comment 7 Theo Linkspfeifer 2019-05-18 01:33:35 CEST

Created attachment 8532 
proposed patch

New try.

Comment 8 Theo Linkspfeifer 2019-05-18 01:44:27 CEST

Created attachment 8533 
Do not cycle backdrop twice

This patch eliminates an unneeded cycle event which also triggered a warning while spamming the cycle command via cli or menu.

(xfdesktop:11260): xfconf-WARNING **: 01:32:47.585: Failed to set property "xfce4-desktop::/backdrop/screen0/monitorVGA-1/workspace0/last-image": Operation was cancelled

Comment 9 Andre Miranda 2019-05-19 18:12:41 CEST

(In reply to Theo Linkspfeifer from comment #8)
> Created attachment 8533 
> Do not cycle backdrop twice
> 
> This patch eliminates an unneeded cycle event which also triggered a warning
> while spamming the cycle command via cli or menu.
> 
> (xfdesktop:11260): xfconf-WARNING **: 01:32:47.585: Failed to set property
> "xfce4-desktop::/backdrop/screen0/monitorVGA-1/workspace0/last-image":
> Operation was cancelled

I launched xfdesktop in a terminal and in another one ran "repeat 100 xfdesktop --next" (zsh), no warnings were printed. Is there another a way to reproduce?

Comment 10 Git Bot 2019-05-19 19:59:16 CEST

Theo Linkspfeifer referenced this bugreport in commit 1967da03f68984dcf3e24e51df4e0005f37b162e

Add Next Background option (Bug #12261)

https://git.xfce.org/xfce/xfdesktop/commit?id=1967da03f68984dcf3e24e51df4e0005f37b162e

Comment 11 Andre Miranda 2019-05-19 20:00:58 CEST

Working as expected for multiple monitors and workspaces, good job, thanks!
The second patch was also merged as discussed on #xfce-dev.