! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfburn desktop uses deprecated media-cdrom Icon
Status:
RESOLVED: FIXED

Comments

Description Kevin Fenzi 2015-09-30 18:15:24 CEST
xfburn uses media-cdrom as it's icon in it's desktop file. 

This was dropped from the freedesktop spec in 2006. 
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#changelog

Should just switch to using the included stock_xfburn icon (or some other shipped icon).
Comment 1 Aaditya Bagga 2017-03-25 15:05:59 CET
Created attachment 7055 
patch for changing default xfburn icon

Hi,

Instead of media-cdrom the media-optical icon can be used.

media-cdrom did not work with adwaita icon theme (Gnome default), while media-optical worked on adwaita and other icon themes that I had installed.
Comment 2 Aaditya Bagga 2017-03-25 15:37:42 CET
Disregard my comment and patch, seems it is preferable to use shipped icons rather than a system icon:

https://bugzilla.redhat.com/show_bug.cgi?id=1265310#c13
Comment 4 Kevin Fenzi 2017-11-10 23:18:11 CET
(In reply to Marcos Mello from comment #3)
> https://src.fedoraproject.org/rpms/xfburn/blob/master/f/xfburn-0.5.4-icon.
> patch
> 
> Ping?

Can you elaborate on what you want here?
Comment 5 Marcos Mello 2017-11-11 17:53:53 CET
The patch fixes this bug, no?
Comment 6 Skunnyk editbugs 2017-11-11 20:06:43 CET
Yes, the patch should be merged.
Comment 7 Git Bot editbugs 2017-11-20 18:38:46 CET
Kevin Fenzi referenced this bugreport in commit f629436b47ec4dcd51771042c1771c523e754ca4

xfburn desktop uses deprecated media-cdrom Icon

https://git.xfce.org/apps/xfburn/commit?id=f629436b47ec4dcd51771042c1771c523e754ca4

Bug #12233

Reported by:
Kevin Fenzi
Reported on: 2015-09-30
Last modified on: 2017-12-11

People

Assignee:
Skunnyk
CC List:
3 users

Version

Attachments

patch for changing default xfburn icon (314 bytes, patch)
2017-03-25 15:05 CET , Aaditya Bagga
no flags

Additional information