! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add a systemd user service for Tumbler
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
Tumbler
Component:
General

Comments

Description Simon McVittie 2015-09-25 19:33:39 CEST
Created attachment 6463 
Add a corresponding systemd user service for the D-Bus session services

When running under a systemd user session, this results in tumblerd
being placed in in its own cgroup, whereas previously it would be a
child of dbus-daemon in the dbus.service cgroup.

It also avoids races between up to three separate instances of the
same executable being started for its three names, which could result
in spurious activation failures if they are used in quick succession,
similar to <https://bugs.freedesktop.org/show_bug.cgi?id=53220> in
telepathy-mission-control.
Comment 1 Simon McVittie 2015-09-25 19:35:55 CEST
Comment on attachment 6463 
Add a corresponding systemd user service for the D-Bus session services

>+systemd_userdir = $(prefix)/lib/systemd/user

Before someone asks: yes, "lib" is really the right place for user services, even on systems that normally set ${libdir} to /usr/lib64 (Red Hat derivatives) or /usr/lib/x86_64-linux-gnu (Debian derivatives).
Comment 2 Simon McVittie 2016-07-22 17:12:07 CEST
See Bug #12238 for more information on the situations in which this user service can be used/tested.
Comment 3 alexxcons editbugs 2018-10-10 22:34:37 CEST
Here a related bug with some more info about how "systemd-cgls" should look like :  https://bugzilla.xfce.org/show_bug.cgi?id=12238
Comment 4 Ali Abdallah editbugs 2018-10-12 21:52:29 CEST
In my opinion, in an ideal world, this file should be added downstream and not upstream. Distro using systemd should patch their packages. Systemd is not universal/portable in any sense, for instance the added service file has no sense at all on the systemd-less Linux Distro and BSD*.

You may tell me that it is just a file and it won't hurt, but it is really wrong to add it on our side "in principle".
Comment 5 alexxcons editbugs 2018-10-13 21:34:00 CEST
I see it as an opt-in, such as ./autogen.sh, which only enables specific features when the according libraries are present. (as well possibly missing on some distros / BSD*)
Comment 6 Git Bot editbugs 2020-05-25 23:19:11 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/tumbler/-/issues/14.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12225

Reported by:
Simon McVittie
Reported on: 2015-09-25
Last modified on: 2020-05-25

People

Assignee:
Ali Abdallah
CC List:
3 users

Version

Attachments

Additional information