Created attachment 6461 [details] [PATCH] Fix color scheme preview on low bit depth displays When running on a 16 bit X display the color scheme preview in the appearances dialog is garbled. Running xfce4-appearance-settings gives the following output: -- (xfce4-appearance-settings:11170): Gdk-WARNING **: Using Cairo rendering requires the drawable argument to have a specified colormap. All windows have a colormap, however, pixmaps only have colormap by default if they were created with a non-NULL window argument. Otherwise a colormap must be set on them with gdk_drawable_set_colormap (xfce4-appearance-settings:11170): Gdk-WARNING **: gdkpixbuf-drawable.c:1257: Depth of the source drawable is 24 where as the visual depth of the colormap passed is 16 -- The attached patch fixes this by passing the root window and its depth for default values to gdk_pixmap_new().
Thanks for the patch! I tested it and did not see any issue, so it's been applied at: https://git.xfce.org/xfce/xfce4-settings/commit/?id=683822cdb02fdbee0a33f767af3dc5caa998d2c8