[greg@greg-desktop ~]$ uname -a Linux greg-desktop 4.1.6-1-ARCH #1 SMP PREEMPT Mon Aug 17 08:52:28 CEST 2015 x86_64 GNU/Linux I'm running nvidia binary blob 352.30-3 I have one vertical monitor and one horizontal. When I attempt to take screenshots I get garabage in empty space whete there should be black bars: See attachment
Created attachment 6436 What I get
Created attachment 6437 What I expect excuse bad paint job
This seems to be easy to solve, looking at gnome-screenshot: https://git.gnome.org/browse/gnome-screenshot/tree/src/screenshot-utils.c?id=4ca7ed51411a76665891e4d9c2c26b945936c9d3#n193 I have used this function "mask_monitors" (plus a couple other functions) and works like a charm. After the GTK3 port I might used their approach to fix this bug.
Created attachment 7768 commit-d3f56d9-Blank_pixels_outside_monitor_bounds I've tried a few methods and this is the best I've found. It works by: * Checking if there are actually multiple monitors. * Create a region with the screenshot dimensions. * Subtract the geometries of each of the monitors from the region, leaving a mask of pixels not inside a monitor. * Set each of those pixels to black. I've tested this on my triple monitor (one portrait) configuration without problems.
Funny, I can't reproducible this bug anymore with 1.9.2, now that I'm using mesa+nouveau. I tried the Intel driver, with DRI3 it's garbage, flickering a lot, still the screenshots are ok. With DRI2 works fine. Unfortunately I'm unable to make the nvidia drivers work (this piece of s***), gotta try with another pc... @Ben, are you experiencing this issue while using nvidia drivers? By the way, your patch looks good to me, I just need to properly test it before pushing to master.
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-screenshooter/-/issues/7. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev