! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Show recent apps along with favourites
Status:
RESOLVED: WONTFIX
Severity:
enhancement
Product:
Xfce4-whiskermenu-plugin
Component:
General

Comments

Description Yan Pas 2015-08-30 15:37:09 CEST
It would be fine to see some recent apps next to favourites, like it is made in Windows Start Menu
Comment 1 coth 2015-09-02 16:54:24 CEST
This should be really useful to merge favorites with recent. So favorites would be always stuck in recent.
Comment 2 Graeme Gott editbugs 2015-09-02 22:49:19 CEST
Personally, I loathe merged favorites and recent. I know that some people prefer it, but I will only add it if I can come up with a way to make it support both ways.
Comment 3 Yan Pas 2015-09-02 23:26:45 CEST
One more tick to merge both of settings and variable that represents number of recent apps is simple and smart solution, isn't it? Also why the number of recent apps is hard coded to ten? Half of space is empty when i choose recent
Comment 4 Graeme Gott editbugs 2015-09-03 00:18:39 CEST
Internally the code is a lot more complicated than that. Where it saves things, the objects internally that track favorites and recent, etc. How to expose it in the settings interface is not a problem. :)

Recent is not hardcoded to 10 items in git. I have not yet released a stable version with the setting for selecting the amount of recent items.
Comment 5 coth 2015-09-03 00:45:32 CEST
(In reply to Graeme Gott from comment #4)
So Favorites can't just be rendered atop of Recent in Recent category, while Foverites hidden?
Comment 6 Graeme Gott editbugs 2015-09-03 02:45:06 CEST
I can show both the favorites and recent GtkTreeView widgets at the same time, sure, but it looks a little strange. They have separate GtkTreeModels and there is empty space at the bottom of the favorites (or a scroll bar if there are too many to fit, and that looks really odd).
Comment 7 coth 2015-09-03 03:34:10 CEST
(In reply to Graeme Gott from comment #6)
Can't Recent GtkTreeModels be populated by Favorites first in case if option is selected?
Comment 8 coth 2015-09-03 03:36:15 CEST
(In reply to Graeme Gott from comment #4)
> Recent is not hardcoded to 10 items in git. I have not yet released a stable
> version with the setting for selecting the amount of recent items.
Isn't 1.5.0 already has it? It seem to work.
Comment 9 Yan Pas 2015-09-03 06:14:13 CEST
@coth Oh, really, this setting has appeared in 1.5! I was inattentitive :)
Comment 10 Graeme Gott editbugs 2015-09-03 11:27:03 CEST
(In reply to coth from comment #7)
> (In reply to Graeme Gott from comment #6)
> Can't Recent GtkTreeModels be populated by Favorites first in case if option
> is selected?
They would still be separate GtkTreeModels, though. As you added things to your Favorites, or ran new programs, they would become different. The Recent GtkTreeModel would push the favorites off the bottom as you ran new programs, and it wouldn't know about the favorites you add or remove.
Comment 11 Michael Kogan 2015-10-03 14:15:09 CEST
If this is to be added, please make it optional, actually, I like the way it works now.
Comment 12 Graeme Gott editbugs 2016-07-19 16:56:22 CEST
After trying several approaches, I have come to the conclusion that the only reasonable way to implement this is to have an option to show both GtkTreeViews. It does look a little odd when there are scrollbars, but at least it doesn't break things.
Comment 13 coth 2016-07-19 17:07:09 CEST
If optionally on, why not to have a third treeview populated separately? With a simple separator between favorites, at top, and recently used.
Comment 14 Graeme Gott editbugs 2016-07-19 17:13:23 CEST
The code for populating the favorites and recent are part of the favorites and recent treeviews, and splitting that out makes the code quite messy and buggy. Also, favorites allows drag-and-drop and sorting and recent does not, so how would the third treeview handle that?
Comment 15 coth 2016-07-21 22:09:19 CEST
(In reply to Graeme Gott from comment #14)
> The code for populating the favorites and recent are part of the favorites
> and recent treeviews, and splitting that out makes the code quite messy and
> buggy. Also, favorites allows drag-and-drop and sorting and recent does not,
> so how would the third treeview handle that?

Well, i'm not familiar with GTK and C, but with Delphi VCL/Lazarus LCL and its bastard brother .Net Windows Forms you can simply check whatever drag ends up below separator, and if so, you can simply disaccept it.
Comment 16 Graeme Gott editbugs 2016-07-22 11:15:27 CEST
(In reply to coth from comment #15)
> Well, i'm not familiar with GTK and C, but with Delphi VCL/Lazarus LCL and
> its bastard brother .Net Windows Forms you can simply check whatever drag
> ends up below separator, and if so, you can simply disaccept it.

It's more complicated than that. The code that populates and maintains the favorites and recent is separate, and not compatible with each other, and not abstracted to manage other GtkTreeModels. Making it so would require rewriting the guts of Whisker Menu, which I will *not* do.

Will you use this feature if they are stacked listviews? If not, there is no point in me merging the code I have already written to handle that. It is either stacked, or not at all.
Comment 17 coth 2016-07-24 23:27:12 CEST
Not sure i understand what you mean by stacked listview.
Comment 18 Graeme Gott editbugs 2016-07-25 00:19:58 CEST
Created attachment 6750 
stacked listview preview

The favorites are on top, and the recently used are on bottom. Stacked listviews as in vertically stacked--one above the other.
Comment 19 Yan Pas 2016-07-25 10:05:18 CEST
Sounds good, can you post screenshot please?
Comment 20 coth 2016-07-25 10:15:25 CEST
ah, well. doesn't look nice, honestly. it won't be scrollable, so recent list will be difficult to use.
Comment 21 Graeme Gott editbugs 2016-07-25 11:55:16 CEST
Created attachment 6751 
stacked listview with label preview

The recent and favorites are both scrollable. They each have their own scrollbar, so they are just as usable as they are right now.

It does look a little strange, so I tried adding a label above the recently used. How about now?
Comment 22 coth 2016-07-25 11:57:07 CEST
well, the main problem is that favorites takes too much space and recent is in very little window.
Comment 23 Graeme Gott editbugs 2016-07-25 12:09:30 CEST
(In reply to coth from comment #22)
> well, the main problem is that favorites takes too much space and recent is
> in very little window.

Recent and favorites are the exact same size. It's an optical illusion if they don't look the same height; possibly from the scrollbar next to recent, or maybe because recent is the listview on the bottom.
Comment 24 coth 2016-07-25 12:31:47 CEST
That's the problem. Recent usually much longer than favorites. Usually i have 4-6 favorites and 10-14 recent. So this is really hard to use, as favorites won't scroll with recent. With dynamic height respectively of number of items inside it and optional remove of descriptions from favorites/recent could make it a bit better, but still not as good as on Windows 5.1-6.1.
Comment 25 Graeme Gott editbugs 2016-07-25 14:39:09 CEST
Created attachment 6752 
horizontal stacked listviews preview

Okay, what about horizontally stacked listviews? Again, I am not willing to merge them, but I am trying to meet you halfway.

FYI, you can already remove the descriptions.
Comment 26 Graeme Gott editbugs 2018-04-15 11:12:53 CEST
I have changed the layout code and it is no longer possible to even have stacked listviews. Sorry, I don't see any way to support this.

Bug #12175

Reported by:
Yan Pas
Reported on: 2015-08-30
Last modified on: 2018-04-15

People

Assignee:
Graeme Gott
CC List:
2 users

Version

Attachments

stacked listview preview (47.29 KB, image/png)
2016-07-25 00:19 CEST , Graeme Gott
no flags
stacked listview with label preview (63.88 KB, image/png)
2016-07-25 11:55 CEST , Graeme Gott
no flags
horizontal stacked listviews preview (63.51 KB, image/png)
2016-07-25 14:39 CEST , Graeme Gott
no flags

Additional information