! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Please add Microphone control
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-pulseaudio-plugin
Component:
General

Comments

Description Yan Pas 2015-07-27 13:19:42 CEST
Please add scroller to regulate sensitivity of default source (mic)
Or at least tick to mute default input (microphone)
Comment 1 Andrzej editbugs 2016-03-14 20:57:04 CET
This is a good idea and I was planning it for some time now. However, atm I have no time to add new features to the plugin. If you can produce a patch I will gladly review it and push it to git.
Comment 2 Viktor Odintsev editbugs 2017-05-13 03:50:15 CEST
I think this patch to xfce4-volumed-pulse can be ported to pulseaudio-plugin so it will support mic mute button: https://git.xfce.org/apps/xfce4-volumed-pulse/commit/?id=268bc81455ebd3b3a10a4295927776b28d3fd2fe
Comment 3 Viktor Odintsev editbugs 2017-05-13 17:28:37 CEST
Created attachment 7107 
Add XF86AudioMicMute key support

Here's what I got.

With this patch plugin will manage mic mute state and display appropriate notifications.

Icons were borrowed from Gnome icon theme. The only thing I don't sure is whether they will conflict with similar icons in hicolor directory. It seems that audio-volume-* icons are not.
Comment 4 Andrzej editbugs 2017-05-20 14:34:15 CEST
Sorry for the late response, I've been travelling.

The patch looks OK but I have no way of testing it with my keyboard. Do you mind extending the menu with a "Mute microphone" check box? A slider for microphone volume would be good as well.

I've committed your patch to git master. Thanks.
Comment 5 Viktor Odintsev editbugs 2017-05-20 15:38:06 CEST
> Do you mind extending the menu with a "Mute microphone" check box? A slider for microphone volume would be good as well.
I think it's a good idea. I'll try to do it later.
Comment 6 Viktor Odintsev editbugs 2017-05-21 01:48:32 CEST
Created attachment 7113 
Add mic control in the plugin menu
Comment 7 Andrzej editbugs 2017-05-21 14:15:56 CEST
Hi Viktor,

These are good quality patches. Thank you for your work. If you would like to have commit rights to xfce4-pulseaudio-plugin pop into #xfce-dev and let me know.

By the way, please send me a patch for the contributors list and copyrights notices in changed files.

Patch 0002 pushed to git master.
Comment 8 Andrzej editbugs 2017-05-21 17:59:13 CEST
I've added your gmail address to credits and copyright notices. Please let me know if you would rather have it removed/changed.

Closing this bug as fixed.
Comment 9 Viktor Odintsev editbugs 2017-05-21 19:07:29 CEST
> If you would like to have commit rights to xfce4-pulseaudio-plugin pop into #xfce-dev and let me know.
I don't think I'll regularly make patches so I don't need this.

> I've added your gmail address to credits and copyright notices. Please let me know if you would rather have it removed/changed.
Thanks, that's fine by me.

Bug #12097

Reported by:
Yan Pas
Reported on: 2015-07-27
Last modified on: 2017-05-21

People

Assignee:
Andrzej
CC List:
2 users

Version

Version:
unspecified

Attachments

Add XF86AudioMicMute key support (57.56 KB, patch)
2017-05-13 17:28 CEST , Viktor Odintsev
ninetls : review? ( andrzejr )
Add mic control in the plugin menu (11.51 KB, patch)
2017-05-21 01:48 CEST , Viktor Odintsev
ninetls : review? ( andrzejr )

Additional information