! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
printing-systems/lprng/lprng.c - missing includes
Status:
RESOLVED: LATER
Product:
Xfprint4
Component:
General

Comments

Description Oliver Lehmann 2005-11-05 11:06:51 CET
Hi,

lprng.c misses two includes which prevents xfprint from compiling (at least on
FreeBSD). The fix is:

--- printing-systems/lprng/lprng.c.orig Mon Oct 31 23:32:02 2005
+++ printing-systems/lprng/lprng.c      Sat Nov  5 11:51:11 2005
@@ -31,6 +31,8 @@
 #include <libxfcegui4/libxfcegui4.h>
 #include <libxfce4util/libxfce4util.h>
 #include <printing-system.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
 
 #include <netdb.h>
 


Reproducible: Always
Steps to Reproduce:
1. svn up
2. ./autogen.sh
3. gmake

Actual Results:  
 cc -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/local/include -I../.. -I../../common
-DXTHREADS -DXUSE_MTSAFE_API -I/usr/local/include/glib-2.0
-I/usr/local/lib/glib-2.0/include -I/usr/local/include/atk-1.0
-I/usr/X11R6/include -I/usr/X11R6/include/xfce4 -I/usr/X11R6/include/gtk-2.0
-I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include/pango-1.0
-I/usr/local/include/freetype2 -I/usr/local/include
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-DPRINTCAP_PATH=\"/etc/printcap\"
-DPACKAGE_LOCALE_DIR=\"/usr/X11R6/share/locale\" -I/usr/local/include -MT
lprng_plugin_la-lprng.lo -MD -MP -MF .deps/lprng_plugin_la-lprng.Tpo -c lprng.c
 -fPIC -DPIC -o .libs/lprng_plugin_la-lprng.o
lprng.c: In function `printing_system_get_jobs_list_impl':
lprng.c:193: error: storage size of 'sock_addr' isn't known
lprng.c:194: error: storage size of 'server_addr' isn't known
lprng.c:208: error: dereferencing pointer to incomplete type
lprng.c:211: error: `AF_INET' undeclared (first use in this function)
lprng.c:211: error: (Each undeclared identifier is reported only once
lprng.c:211: error: for each function it appears in.)
lprng.c:215: error: `PF_INET' undeclared (first use in this function)
lprng.c:215: error: `SOCK_STREAM' undeclared (first use in this function)
Comment 1 Jean-François Wauthy editbugs 2006-06-04 18:25:02 CEST
lprng support is (unfortunately) on hold

there is some code in SVN (that doesn't compile since i changed the plugin interface) but it won't be released with 4.4

Bug #1209

Reported by:
Oliver Lehmann
Reported on: 2005-11-05
Last modified on: 2009-07-14

People

Assignee:
Jean-François Wauthy
CC List:
0 users

Version

Attachments

Additional information