! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Provide an option to list the "tool tip" string in the panel
Status:
RESOLVED: MOVED
Product:
Xfce4-mpc-plugin
Component:
General

Comments

Description Matt Zagrabelny 2015-07-16 18:46:39 CEST
Greetings,

Thanks for your contribution to XFCE. It is appreciated!

I use window manager keybindings for controlling MPD, but would love to have current song info listed in the panel.

Would you please provide an option to not display the controls and instead list the tool tip string in the panel?

Thanks for your consideration!

Cheers,

-m
Comment 1 Landry Breuil editbugs 2015-07-17 13:38:04 CEST
Hm, i dont really like this, for several reasons:

- it adds one more knob to the config, the plugin wasnt meant to be more than just a simple control client
- it would mean polling every X seconds the server to know the currently playing track, which would be resource-consuming and require some architecture changes. Right now, the plugin connects to the server *only* if the mouse is over it for the tooltip or to get the status/outputs.
- how would it fit graphically in a panel ? The tooltip string length can change *a lot*, so should the space vary according to this ? A fixed maximum width ? Text scrolling ? All that would be ugly.


To be honest, you can also use conky to do this and display mpd status on your root desktop window..;
Comment 2 Matt Zagrabelny 2015-07-17 15:59:37 CEST
Hi Landry,

Thanks for the comments.

(In reply to Landry Breuil from comment #1)
> Hm, i dont really like this, for several reasons:
> 
> - it adds one more knob to the config, the plugin wasnt meant to be more
> than just a simple control client

So then new features shouldn't be added? I'd rather "improve" on one common software than fork or start a new project.

> - it would mean polling every X seconds the server to know the currently
> playing track, which would be resource-consuming and require some
> architecture changes. Right now, the plugin connects to the server *only* if
> the mouse is over it for the tooltip or to get the status/outputs.

It wouldn't be any more expensive than any of the dozens of other MPD clients out there - they all show the current song (amongst other data). I'd imagine there is some mechanism to receive updates that isn't terribly resource intensive.

> - how would it fit graphically in a panel ? The tooltip string length can
> change *a lot*, so should the space vary according to this ? A fixed maximum
> width ? Text scrolling ? All that would be ugly.

Ugly is in the eye of the beholder.

> To be honest, you can also use conky to do this and display mpd status on
> your root desktop window..;

Yep. I know about conky, but I'd like something in the panel.

It doesn't sound like you are champing at the bit to work on this. Would you consider a patch?

Thanks!

-m
Comment 3 Landry Breuil editbugs 2015-07-22 21:27:55 CEST
(In reply to Matt Zagrabelny from comment #2)
> Hi Landry,
> 
> Thanks for the comments.
> 
> (In reply to Landry Breuil from comment #1)
> > Hm, i dont really like this, for several reasons:
> > 
> > - it adds one more knob to the config, the plugin wasnt meant to be more
> > than just a simple control client
> 
> So then new features shouldn't be added? I'd rather "improve" on one common
> software than fork or start a new project.
> 
> > - it would mean polling every X seconds the server to know the currently
> > playing track, which would be resource-consuming and require some
> > architecture changes. Right now, the plugin connects to the server *only* if
> > the mouse is over it for the tooltip or to get the status/outputs.
> 
> It wouldn't be any more expensive than any of the dozens of other MPD
> clients out there - they all show the current song (amongst other data). I'd
> imagine there is some mechanism to receive updates that isn't terribly
> resource intensive.

Yes, maybe, but that means architecture changes. Which adds complexity. Have you looked at the alternative provided by simple-libmpd.c ? There's no way i'll add a callback-mechanism to it mimicking what the one from libmpd does...

> > - how would it fit graphically in a panel ? The tooltip string length can
> > change *a lot*, so should the space vary according to this ? A fixed maximum
> > width ? Text scrolling ? All that would be ugly.
> 
> Ugly is in the eye of the beholder.

Your sentence doesnt really help the discussion here. I raised some valid UI concerns, to which you absolutely didnt reply.. 

> > To be honest, you can also use conky to do this and display mpd status on
> > your root desktop window..;
> 
> Yep. I know about conky, but I'd like something in the panel.

Then you can try the genmon plugin. And then you'll realize it's not so easy to fit variable-width text on the panel....
Comment 4 Matt Zagrabelny 2015-07-22 22:43:07 CEST
(In reply to Landry Breuil from comment #3)
> (In reply to Matt Zagrabelny from comment #2)
> > Hi Landry,
> > 
> > Thanks for the comments.
> > 
> > (In reply to Landry Breuil from comment #1)
> > > Hm, i dont really like this, for several reasons:
> > > 
> > > - it adds one more knob to the config, the plugin wasnt meant to be more
> > > than just a simple control client
> > 
> > So then new features shouldn't be added? I'd rather "improve" on one common
> > software than fork or start a new project.
> > 
> > > - it would mean polling every X seconds the server to know the currently
> > > playing track, which would be resource-consuming and require some
> > > architecture changes. Right now, the plugin connects to the server *only* if
> > > the mouse is over it for the tooltip or to get the status/outputs.
> > 
> > It wouldn't be any more expensive than any of the dozens of other MPD
> > clients out there - they all show the current song (amongst other data). I'd
> > imagine there is some mechanism to receive updates that isn't terribly
> > resource intensive.
> 
> Yes, maybe, but that means architecture changes.

Alright.

 Which adds complexity. Have
> you looked at the alternative provided by simple-libmpd.c ?

Not yet.

 There's no way
> i'll add a callback-mechanism to it mimicking what the one from libmpd
> does...

That sounds definitive.

> 
> > > - how would it fit graphically in a panel ? The tooltip string length can
> > > change *a lot*, so should the space vary according to this ? A fixed maximum
> > > width ? Text scrolling ? All that would be ugly.
> > 
> > Ugly is in the eye of the beholder.
> 
> Your sentence doesnt really help the discussion here. I raised some valid UI
> concerns, to which you absolutely didnt reply.. 

I was just stating a difference of opinion. You think something is ugly - I don't.

Here is the solution:

Let the user decide:

[x] Fixed width (with potential scrolling) [enter pixel width  here]
[ ] Variable width

> 
> > > To be honest, you can also use conky to do this and display mpd status on
> > > your root desktop window..;
> > 
> > Yep. I know about conky, but I'd like something in the panel.
> 
> Then you can try the genmon plugin. And then you'll realize it's not so easy
> to fit variable-width text on the panel....

I'll look into genmon.

Thanks!

-m
Comment 5 Git Bot editbugs 2020-05-23 00:14:21 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-mpc-plugin/-/issues/1.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12074

Reported by:
Matt Zagrabelny
Reported on: 2015-07-16
Last modified on: 2020-05-23

People

Assignee:
Landry Breuil
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information