xfce4 version 4.2.2. When building on solaris 10 x86 from pkgsrc I receive compiler errors in function create_summary_tab and the build exits. Reproducible: Always Steps to Reproduce: 1. cd pkgsrc/misc/xfce4-weather-plugin 2. bmake install 3. after fixing the mixer plugin build as described in another forum, everything will build for xfce, except the weather plugin Actual Results: summary_window.c: In function `create_summary_tab': summary_window.c:25: error: syntax error before numeric constant summary_window.c:112: error: invalid lvalue in assignment summary_window.c:114: warning: pointer/integer type mismatch in conditional expression summary_window.c:116: warning: passing arg 1 of `g_free' makes pointer from integer without a cast summary_window.c:120: error: invalid lvalue in assignment summary_window.c:122: warning: pointer/integer type mismatch in conditional expression summary_window.c:124: warning: passing arg 1 of `g_free' makes pointer from integer without a cast summary_window.c:130: error: `vis' undeclared (first use in this function) summary_window.c:130: error: (Each undeclared identifier is reported only once summary_window.c:130: error: for each function it appears in.) gmake: *** [libweather_la-summary_window.lo] Error 1 Expected Results: The plugin should have been built and installed Here is the link to the xfce forum post, where others are having similar issues with building on solaris/solaris (sparc). There is a listed fix that works for the mixer plugin and allows compilation to continue until you get to the weather plugin, for which, I've found no fix. http://www.os-cillation.de/cgi-bin/yabb/YaBB.cgi?board=Help;action=display;num=1109782807 You can see that I receive the same error in the weather plugin as another user two xfce versions ago and several lines have been added to summary_window.c since then. # gcc -v Reading specs from /usr/sfw/lib/gcc/i386-pc-solaris2.10/3.4.3/specs Configured with: /builds/sfw10-gate/usr/src/cmd/gcc/gcc-3.4.3/configure --prefix=/usr/sfw --with-as=/usr/sfw/bin/gas --with-gnu-as --with-ld=/usr/ccs/bin/ld --without-gnu-ld --enable-languages=c,c++ --enable-shared Thread model: posix gcc version 3.4.3 (csl-sol210-3_4-branch+sol_rpath) -- GNU Make 3.80 --
Created attachment 334 Patch to fix this
It seems that a header is included which defines the a symbolic constant named "sun". As the code tries to declare a variable named "sun" it obviously doesn't work. The attached patch should fix this by changing the name of the variable used. Apply with path -p0 < sun_patch.diff
Thanks I appilied your patch to panel-plugin/summary_window.c This fixed the issue and the build completed smoothly
A bit late... but it's fixed in trunk. Thanks for the patch.
Re-assigning to Colin Leroy who is the new maintainer of the plugin.