! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
MPRIS2: PropertiesChanged signal is NOT emitted when shuffle is toggled
Status:
RESOLVED: FIXED

Comments

Description el boulangero 2015-07-04 23:38:13 CEST
Created attachment 6364 
Patch

Just spotted that while looking at the code, patch attached.
Comment 1 Matias De lellis 2015-07-14 14:40:57 CEST
Hi

At first sight, it seems right.. But now that I test, it seems that neither send the signal when changing repeat option.. :S

In a few hours, I can investigate better.. Thanks for the patch!. =)
Comment 2 el boulangero 2015-07-14 16:58:55 CEST
Changing the repeat option fires the right signal for me. Are you sure that MPRIS2 is enabled in the plugins list ? And that you're watching the right DBus object (aka MPRIS2) ?

    $ dbus-monitor "type='signal',sender='org.mpris.MediaPlayer2.parole'"
Comment 3 Matias De lellis 2015-07-14 17:31:44 CEST
Hi,
You are right.. Sorry.. ;)
Then I tried other players and mpris2-status-icon not managed well these.. haha..

I did the same test and confirm it..

Let me try this afternoon, and surely add your patch. =)

Regards,
Matias.
Comment 4 Matias De lellis 2015-07-15 15:17:44 CEST
Hi,
Again thank you and confirms you are right... :)

Sorry for the delay, but just the Shuffle interface is not very standard (Mpris2 talks about Loop status like "None", "Track" or "Playlist" and parole only supports "None" and "Playlist"). Then I suspected it might have been deliberately.

Now that tested, and see the commits.. +1

Simon,
Please, apply the patch..
Comment 5 Simon Steinbeiss editbugs 2015-07-15 15:25:47 CEST
Pushed, thanks for checking!
http://git.xfce.org/apps/parole/commit/?id=182b27328a03296f8cca88a0db01a5771ea78358

Bug #12045

Reported by:
el boulangero
Reported on: 2015-07-04
Last modified on: 2015-07-15

People

Assignee:
Simon Steinbeiss
CC List:
2 users

Version

Attachments

Patch (1.06 KB, patch)
2015-07-04 23:38 CEST , el boulangero
no flags

Additional information