Patch coming to cache thumbnails for files which are on removable media, on the removable media itself; and to continue to store other thumbnails in $XDG_CACHE_HOME as before. See the commit message for more details.
Created attachment 6356 xdg-cache: Store removable media thumbnails on removable media This means the files don’t have to be re-thumbnailed for every computer the drive is mounted on; and conversely, each computer doesn’t have to worry about the cache lifetime of files on removable disks which it may never see again. Based on a patch by Jeremy Whiting <jeremy.whiting@collabora.co.uk>.
Created attachment 6371 xdg-cache: Factor out directory copy-or-move function This introduces no functional changes but will make later refactoring simpler.
Created attachment 6372 xdg-cache: Ensure read_thumbnail_info() always sets an error on failure It’s GError convention to set the GError exactly when returning FALSE from a boolean-valued function. read_thumbnail_info() didn’t do that if libpng reported an error loading the PNG; fix that by returning TUMBLER_ERROR_INVALID_FORMAT in that case.
Created attachment 6373 xdg-cache: Support loading thumbnails from shared repositories The thumbnail specification defines shared repositories as optional read-only repositories stored relative to the media files, which can therefore be shared between multiple users and computers. This could be useful for removable media, for example. http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html#SHARED Add read-only support for shared repositories, preferring to load the thumbnail from the local repository ($XDG_CACHE_HOME/thumbnails), but using the shared repository if that fails. Based on a patch by Jeremy Whiting <jeremy.whiting@collabora.co.uk>.
Created attachment 6374 xdg-cache: Store removable media thumbnails on removable media This means the files don’t have to be re-thumbnailed for every computer the drive is mounted on; and conversely, each computer doesn’t have to worry about the cache lifetime of files on removable disks which it may never see again. Based on a patch by Jeremy Whiting <jeremy.whiting@collabora.co.uk>.
Here’s an updated patch set which splits out reading of thumbnails from writing of them, and separates the (potentially contentious) change to write to shared repositories into a commit of its own.
Created attachment 6376 xdg-cache: Support loading thumbnails from shared repositories Updated patch to fix some URI-vs-path issues and add a bit more debug output. --- The thumbnail specification defines shared repositories as optional read-only repositories stored relative to the media files, which can therefore be shared between multiple users and computers. This could be useful for removable media, for example. http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html#SHARED Add read-only support for shared repositories, preferring to load the thumbnail from the local repository ($XDG_CACHE_HOME/thumbnails), but using the shared repository if that fails. Based on a patch by Jeremy Whiting <jeremy.whiting@collabora.co.uk>.
Created attachment 6377 xdg-cache: Store removable media thumbnails on removable media Updated for changes to attachment #6376 . --- This means the files don’t have to be re-thumbnailed for every computer the drive is mounted on; and conversely, each computer doesn’t have to worry about the cache lifetime of files on removable disks which it may never see again. Based on a patch by Jeremy Whiting <jeremy.whiting@collabora.co.uk>.
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/tumbler/-/issues/12. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev