! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Settings for monitors with names containing whitespace fails
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Andreas Müller 2015-06-25 14:09:16 CEST
Created attachment 6337 
Patch

After updating 4.10.2 -> 4.12.2 setting for Desktop stopped working on some of my machines.

It turned out that this was caused by Monitor name containing white spaces - details see patch attached.

I am not sure 

* if this matches codes standards here - have not found a suitable glibc/glib function
* if settings-names containing spaces should be handled in xfconf properly.
* if white spaces should be removed instead of removed
Comment 1 Andreas Müller 2015-06-25 16:17:15 CEST
OOps I meant

* if white spaces should be replaced instead of removed
Comment 2 Eric Koegel editbugs 2015-06-28 07:30:09 CEST
Thanks! Pushed to master in:
commit da068958d30e702895de28405711b63efadb57ae
Author: Andreas Müller <schnitzeltony@googlemail.com>
Date:   Thu Jun 25 13:08:29 2015 +0200

    Remove whitespaces from monitor name when accessing settings
    
    Desktop wallpaper could not be set here. Running
    'xfdesktop-settings --enable-debug' lead to:
    
    | Saving to /backdrop/screen0/monitorDISP3 BG - DI1/workspace0/last-image//usr/share/backgrounds/xfce/xfce-blue.jpg
    
    and no change was found tracking with Settings Editor.
    
    Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
http://git.xfce.org/xfce/xfdesktop/commit/?id=da068958d30e702895de28405711b63efadb57ae

I also pushed a tiny commit after for the signed/unsigned mismatch
http://git.xfce.org/xfce/xfdesktop/commit/?id=c0a890316472891260ffda4847f8c2b409dc52f2

I'll cherry-pick this into the next 4.12 stable release when that happens. Thanks again.

Bug #12015

Reported by:
Andreas Müller
Reported on: 2015-06-25
Last modified on: 2015-06-28

People

Assignee:
Eric Koegel
CC List:
1 user

Version

Version:
4.12.1

Attachments

Patch (4.97 KB, patch)
2015-06-25 14:09 CEST , Andreas Müller
no flags

Additional information