! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-panel crashes on commands with empty 'Command' field
Status:
CLOSED: FIXED
Severity:
trivial
Product:
Xfce4-panel

Comments

Description jimmy 2003-11-17 12:45:14 CET
When running an application from the panel, no check is
made if it's "Command" field is empty. So when it is, any
attempt to run the command ends with signal11 due to the
command->cmd field being NULL, and the panel is restarted.
Comment 1 jimmy 2003-11-17 12:45:16 CET
Additional information:

I found this in 4.0.0 and wrote to xfce4-dev@xfce.org, but
the mail seems to got lost. Anyway, the patch applies to
4.0.1 as well.
Comment 2 d_osh 2003-11-17 14:45:33 CET
Seems like this is fixed 4.0.1. I make a launcher with an empty 'Command'
field, click it, and nothing happens (no panel crash).
Comment 3 Jasper Huijsmans editbugs 2003-11-17 15:07:24 CET
Hmm, I am quite sure that check used to be there ...

Anyway, it doesn't crash for me either, but it is definitely a bug.

I'm about to commit the following patch to CVS (yours was fine as well, this
one will complain a bit more ;-)

Thanks,
Jasper


Index: xfce_support.c
===================================================================
RCS file: /var/cvs/xfce/xfce4/xfce4/panel/xfce_support.c,v
retrieving revision 1.47
diff -u -r1.47 xfce_support.c
--- xfce_support.c 7 Aug 2003 19:05:04 -0000 1.47
+++ xfce_support.c 17 Nov 2003 15:05:09 -0000
@@ -982,6 +982,7 @@
void
exec_cmd (const char *cmd, gboolean in_terminal, gboolean use_sn)
{
+ g_return_if_fail (cmd != NULL);
schedule_exec(cmd, in_terminal, use_sn, FALSE);
}

@@ -989,5 +990,6 @@
void
exec_cmd_silent (const char *cmd, gboolean in_terminal, gboolean use_sn)
{
+ g_return_if_fail (cmd != NULL);
schedule_exec(cmd, in_terminal, use_sn, TRUE);
}
Comment 4 Jasper Huijsmans editbugs 2003-11-17 15:36:14 CET
Setting status to resolved. I will close the bug when a version containing the
fix is released.
Comment 5 Jasper Huijsmans editbugs 2003-12-23 13:09:39 CET
fixed in 4.0.2

Bug #12

Reported by:
jimmy
Reported on: 2003-11-17
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

0000012-xfce4-panel-4.0.0-isnull.diff (550 bytes, application/octet-stream)
2003-11-17 12:45 CET , jimmy
no flags

Additional information