! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Systray causes segfault
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Simon Steinbeiss editbugs 2015-06-06 14:07:09 CEST
When enabling the systray in xfce4-power-manager 1.5.1 it segfaults.

Here go the relevant debug output parts:

TRACE[xfpm-manager.c:747] xfpm_manager_show_tray_icon(): Showing tray icon
TRACE[../panel-plugins/power-manager-plugin/power-manager-button.c:531] power_manager_button_add_device(): entering for /org/freedesktop/UPower/devices/DisplayDevice
TRACE[../panel-plugins/power-manager-plugin/power-manager-button.c:441] power_manager_button_update_device_icon_and_details(): entering for /org/freedesktop/UPower/devices/DisplayDevice
TRACE[xfpm-power-common.c:190] get_device_icon_name(): icon_suffix (null), icon_base_length 2147483647, upower_icon 
*** Error in `xfce4-power-manager': free(): invalid pointer: 0x09b33178 ***
Aborted (core dumped)
Comment 1 Olivier Duchateau 2015-06-06 15:54:34 CEST
I've just tested the latest release (under FreeBSD), when enabling the systray, there is no crash, but icon is missing like bug #11931.
Comment 2 poma 2015-06-06 16:45:28 CEST
*** Bug 11968 has been marked as a duplicate of this bug. ***
Comment 3 Eric Koegel editbugs 2015-06-08 15:35:51 CEST
Created attachment 6307 
Set label to NULL so we don't crash

Anyone affected, can you try out this patch?
Comment 4 poma 2015-06-08 15:59:10 CEST
(In reply to Eric Koegel from comment #3)
> Created attachment 6307 
> Set label to NULL so we don't crash
> 
> Anyone affected, can you try out this patch?


PASSED

... xfpm-1.5.2
Comment 5 Eric Koegel editbugs 2015-06-08 16:10:51 CEST
Thanks! Pushed to master:
commit 9c766f4f9dfc5185354ab213265efff0d3cc43fd
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Mon Jun 8 16:23:20 2015 +0300

    Set label so we don't crash (Bug #11967)
http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=9c766f4f9dfc5185354ab213265efff0d3cc43fd
Comment 6 Olivier Duchateau 2015-06-08 17:45:19 CEST
(In reply to Eric Koegel from comment #3)
> Created attachment 6307 
> Set label to NULL so we don't crash
> 
> Anyone affected, can you try out this patch?

Tested, everything works fine (and icon in systray reappeared). Thanks!
Comment 7 Simon Steinbeiss editbugs 2015-06-08 17:51:33 CEST
Good to hear, and sorry for the oversight. Sucks, but sometimes these things slip through testing...

Bug #11967

Reported by:
Simon Steinbeiss
Reported on: 2015-06-06
Last modified on: 2015-06-08
Duplicates (1):
  • 11968 *** Error in `xfce4-power-manager': free(): invalid pointer: 0x000000000148c250 ***

People

Assignee:
Ali Abdallah
CC List:
5 users

Version

Attachments

Set label to NULL so we don't crash (941 bytes, patch)
2015-06-08 15:35 CEST , Eric Koegel
no flags

Additional information