! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar needs restart to update the trash
Status:
RESOLVED: FIXED
Priority:
High
Severity:
major
Product:
Thunar
Component:
TPA

Comments

Description tritonas00 2015-05-10 20:56:33 CEST 
Since 1.6.8 trash is not working right.

The icon shows empty trash when deleting items. Also the option "empty trash" is not active.

Restarting thunar updates the trash icon and makes the option active.

Same happens when emptying the trash.
Comment 1 ToZ editbugs 2015-05-11 03:44:43 CEST 
I'm seeing the same. Thunar 1.6.8 and gvfs 1.24.1.

"gvfs-trash --empty" will empty the trash with no change in status from Thunar.

It's inconsistent though - can't seem to locate what triggers the mismatch.
Comment 2 Harald Judt editbugs 2015-05-12 11:05:41 CEST 
Created attachment 6243 
Do-listen-for-G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED.patch

I can reproduce this with gvfs-trash <file> and gvfs-trash --empty. It is caused by http://git.xfce.org/xfce/thunar/commit/?id=a0b81ac84dcfd23f1d310d276e46df13e826fac9.

Thunar needs to listen to G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED; the assumption that this is taken care of in G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT was obviously wrong.

The attached patch fixes this for me.
Comment 3 Harald Judt editbugs 2015-05-12 11:53:33 CEST 
Pushed to master: http://git.xfce.org/xfce/thunar/commit/?id=a0b81ac84dcfd23f1d310d276e46df13e826fac9

Reopen if this does not fix the issue.

Bug #11896

Reported by:
tritonas00
Reported on: 2015-05-10
Last modified on: 2015-05-14

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
1.6.8
Target Milestone:
1.8.0

Attachments

Do-listen-for-G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED.patch (1.21 KB, patch)
2015-05-12 11:05 CEST , Harald Judt 		no flags

Additional information