! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
plugin's icon does not appear
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-power-manager
Component:
General

Comments

Description poma 2015-04-21 16:54:39 CEST
The icon placeholder is in the place and working, only the icon itself is missing.

Fedora 21 & Xfce built of git.

Test compilation:
http://goo.gl/Gm4ffO
ISO/Fedora-21-Live-Xfce-4.12-x64-mini-2015-04-20.iso
runs on baremetal & QEMU/KVM
Comment 1 Simon Steinbeiss editbugs 2015-04-21 17:14:43 CEST
Created attachment 6206 
Fix panel plugin icon not showing up

Hi, I've attached yet another potential fix for the problem. I figured UPower might actually return an empty string, so the attached patch catches that case.
Please check whether that helps!
Comment 2 poma 2015-04-21 19:06:32 CEST
w/ 0001-Fix-plugin-icon-not-showing-up-on-Desktops-Bug-11840.patch
status quo ante
Comment 3 Eric Koegel editbugs 2015-05-23 10:58:56 CEST
Created attachment 6280 
Fix for panel icon on Desktop systems

Can you try out this patch? I was able to reproduce and this works for me. Thanks!
Comment 4 flocculant 2015-05-25 15:13:42 CEST
tried this last patch on xubuntu 15.10 - plugin now remains in panel (was seeing constant crashes) but no icon here
Comment 5 flocculant 2015-05-25 15:30:02 CEST
nix that

removed existing xfpm - rebuilt and installed from git including patch - plugin now has icon
Comment 6 Eric Koegel editbugs 2015-05-25 17:30:04 CEST
Thanks for testing! Pushed to master in:
commit 0dd1196b8fc5c8634f858c4f68e5ff7360a4da01
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Sat May 23 11:44:45 2015 +0300

    Fix for panel icon on Desktop systems (Bug #11840)
    
    This fixes the panel icon on a desktop system with no battery
    devices.
http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=0dd1196b8fc5c8634f858c4f68e5ff7360a4da01
Comment 7 poma 2015-05-26 00:27:18 CEST
(In reply to Eric Koegel from comment #3)
> Created attachment 6280 
> Fix for panel icon on Desktop systems
> 
> Can you try out this patch? I was able to reproduce and this works for me.
> Thanks!

http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=0dd1196
xfce4-power-manager-1.4.4-16.git20150525.fc21.x86_64 - OK
xfce4-power-manager-1.4.4-16.git20150525.fc23.x86_64 - OK
Comment 8 flocculant 2015-05-26 08:22:32 CEST
A dozen restarts yesterday and the icon displayed fine.

This morning - no icon.

Bug #11840

Reported by:
poma
Reported on: 2015-04-21
Last modified on: 2015-05-26

People

Assignee:
Ali Abdallah
CC List:
4 users

Version

Attachments

Fix panel plugin icon not showing up (1.05 KB, patch)
2015-04-21 17:14 CEST , Simon Steinbeiss
no flags
Fix for panel icon on Desktop systems (1.30 KB, patch)
2015-05-23 10:58 CEST , Eric Koegel
no flags

Additional information