! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
highlight by mouse hover is not always deactivated when leaving the window
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
major
Product:
Exo
Component:
Iconview

Comments

Description b3nmore 2015-04-09 16:54:05 CEST 
Hovering over an item in thunars main panel highlights it. If one moves the cursor away from a thunar window and the cursors trajectory passes a partially displayed item (e.g. by the lower window border), the item gets highlighted but never de-highlighted, when cursor leaves the window.

This may lead to serious misbehavior when using thunar in single click activation mode, because the non de-highlighted item gets selected. This way one can loose a selection of files and in the worst case accidentally delete the wrong file.
Comment 1 Theo Linkspfeifer editbugs 2019-06-24 23:40:04 CEST 
This happens in xfce4-settings-manager too, so maybe a bug in exo-icon-view.
Comment 2 Adam Purkrt 2019-10-28 23:22:39 CET 
Created attachment 9159 
0001-Fix-for-the-bug-11806.patch

Fix for the bug. Please test.
Comment 3 Adam Purkrt 2019-10-29 14:03:39 CET 
Created attachment 9162 
0001-Fix-for-the-bug-11806.patch

Updated patch (minor change).
Comment 4 Theo Linkspfeifer editbugs 2019-10-29 18:22:26 CET 
Thanks for the patch. I tested it and it does fix the bug.
Comment 5 Adam Purkrt 2019-10-30 19:35:44 CET 
Created attachment 9166 
0001-Fix-for-the-bug-11806.patch

Still a minor refinement of the patch (moving the GDK_LEAVE_NOTIFY_MASK from the clipping window to the icons window (feels better to have it near the POINTER_MOTION_MASK) and moving the comment before the block).
Comment 6 Git Bot editbugs 2019-11-03 23:44:29 CET 
Adam Purkrt referenced this bugreport in commit 37e00da8247a6b60cad1cc91e734805000cba926

Fix prelight deactivation (bug #11806)

https://git.xfce.org/xfce/exo/commit?id=37e00da8247a6b60cad1cc91e734805000cba926
Comment 7 Sean Davis editbugs 2019-11-03 23:44:58 CET 
Thanks for the patches! Applied the final version above.

Bug #11806

Reported by:
b3nmore
Reported on: 2015-04-09
Last modified on: 2019-11-03

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
unspecified
Target Milestone:
Future

Attachments

0001-Fix-for-the-bug-11806.patch (1.70 KB, patch)
2019-10-28 23:22 CET , Adam Purkrt 		no flags
0001-Fix-for-the-bug-11806.patch (1.73 KB, patch)
2019-10-29 14:03 CET , Adam Purkrt 		no flags
0001-Fix-for-the-bug-11806.patch (1.61 KB, patch)
2019-10-30 19:35 CET , Adam Purkrt 		no flags

Additional information