11778 – xfdesktop: fails to build with 'src/xfdesktop-icon-view.c:1644: undefined reference to `xfdesktop_dnd_menu'' when configured w/ --disable-file-icons

xfdesktop: fails to build with 'src/xfdesktop-icon-view.c:1644: undefined ref...

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfdesktop

Component:

General

Comments

Description Michał Górny 2015-03-29 17:34:02 CEST

Created attachment 6147 
Build log

I can reproduce it with today's git. When xfdesktop is configured with --disable-file-icons, it fails to build:

  CCLD     xfdesktop
xfdesktop-xfdesktop-icon-view.o: In function `xfdesktop_icon_view_drag_drop':
/tmp/xfdesktop/src/xfdesktop-icon-view.c:1644: undefined reference to `xfdesktop_dnd_menu'
collect2: error: ld returned 1 exit status

Attaching a verbose build log from Gentoo user.

Comment 1 Thaddaeus Tintenfisch editbugs

2015-03-29 21:23:28 CEST

Created attachment 6148 
Fix build error

Thanks for reporting this issue.

Comment 2 Michał Górny 2015-04-01 18:23:10 CEST

No problem. I can confirm that the fix works.

Comment 3 Eric Koegel editbugs

2015-04-01 18:45:11 CEST

Thanks for the patch and verifying it works, pushed to master in:
commit 2b4b785210d4d5e7c2763c45004b8153e0270553
Author: Thaddaeus Tintenfisch <thad.fisch@gmail.com>
Date:   Sun Mar 29 18:36:47 2015 +0200

    Fix build error (Bug #11778)
    
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
http://git.xfce.org/xfce/xfdesktop/commit/?id=2b4b785210d4d5e7c2763c45004b8153e0270553

Bug #11778

Reported by:
Michał Górny

Reported on: 2015-03-29
Last modified on: 2015-04-01

People

Assignee:
Eric Koegel

CC List:
1 user

Version

Version:
4.12.0

Target Milestone:
Xfce 4.14

Attachments

Build log (94.96 KB, text/x-log) 2015-03-29 17:34 CEST , Michał Górny	no flags
Fix build error (1.08 KB, patch) 2015-03-29 21:23 CEST , Thaddaeus Tintenfisch	no flags

Additional information