! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Open in terminal doesn't work with terminator
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Directory Menu

Comments

Description Filipp Andjelo 2015-03-22 12:06:40 CET
Since xfce 4.10, directory menu panel plugin has changed it's behavior, currently it gives working directory to the called terminal emulator as an argument, but not all terminal emulators accept it that way. F.e. terminator (which I am using) takes --working-directory=DIR. 

I'm honestly not sure, if it's terminators problem or xfce, but I think directory menu shouldn't assume, that arguments of the default terminal emulator would be always handled that way. It'd be a better solution to change directory before calling the emulator.
Comment 1 Filipp Andjelo 2015-03-31 17:17:54 CEST
Created attachment 6152 
Fix

This fix removes working_dir argument from the call to terminal emulator. Most of terminal emulators should work now. I tested with:

- Xfce Terminal
- Terminator
- VTE
- Sakura
- XTerm
Comment 2 Filipp Andjelo 2015-04-01 20:38:40 CEST
This bug seem to be produced by following patch:

https://bugzilla.xfce.org/show_bug.cgi?id=10270

I don't think that adding paths silently is a good idea.
Comment 3 Steve Dodier-Lazaro editbugs 2015-05-10 16:02:58 CEST
Hi,

Since this patch is reverting previous behaviour, it would be good to also test that the alleged improvement in #10270 hasn't been reverted. With your patch, are file managers still automatically opened in the current working directory of the terminal?
Comment 4 Filipp Andjelo 2015-05-10 20:50:27 CEST
Hi,

sure, the behaviour from #10270 is reverted, but that change was too shortsighted, breaking functionality of many terminal emulators. The solution was only tested with xfce4-terminal, despite that there are also others in the wild. In my opinion #10270 is actually a bug, because it was not enough tested and should never been released.
As I already mentioned, I reverted #10270 changes and tested against multiple terminals, it worked just fine again and the terminals always opened in the right working directory.
Comment 5 Andrzej editbugs 2015-05-15 00:59:18 CEST
Thank you. Pushed a modified patch to master. The argument is only used for starting a file manager, not a terminal emulator.
Comment 6 Simon Steinbeiss editbugs 2017-05-23 00:30:21 CEST
The fix was pushed here: https://git.xfce.org/xfce/xfce4-panel/commit/?id=5565f4cb4db3088cf0a01b5c807c2f57e92ff981
and released with 4.12.1.

Bug #11742

Reported by:
Filipp Andjelo
Reported on: 2015-03-22
Last modified on: 2017-05-23

People

Assignee:
Nick Schermer
CC List:
3 users

Version

Version:
4.12.0

Attachments

Fix (497 bytes, patch)
2015-03-31 17:17 CEST , Filipp Andjelo
no flags

Additional information