! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-mount-plugin-0.6.7 triples its height
Status:
RESOLVED: FIXED
Product:
Xfce4-mount-plugin
Component:
General

Comments

Description Jesús Guerrero Botella 2015-03-20 11:58:34 CET
Created attachment 6098 
Screenshot showing the problem

Hello.

When I use a desktop bar layout with 3 rows my mount plugin becomes deformed as shown in the screenshot that I'll attack. It's way too tall. The problem is merely aesthetic, since it works as always, bit it takes too much space from my panel.

By inserting some verbosity in the mounter_set_size() func I discovered that that function truly never gets called.

So, after trying a few things and given my total lack of g_skills I went the brute way: I force the call of that function by emitting the right signal at the end of mount_construct(), and now it look as it must.

I will also attach the patch. I know it's probably not the right way to do it. But it will at least give you some hint on what the problem might be.
Comment 1 Jesús Guerrero Botella 2015-03-20 11:59:28 CET
Created attachment 6099 
Patch to force the call of mounter_set_size()
Comment 2 Fabian Nowak editbugs 2016-05-29 21:29:03 CEST
(In reply to Jesús Guerrero Botella from comment #1)
> Created attachment 6099 
> Patch to force the call of mounter_set_size()

Sorry, I can't reproduce that. You correctly observed that the plugin itself does not directly call set_size(); instead when changing the orientation or size the panel is expected to do so. Anyway, with the Gtk3 support now with Git Version 1.0.0 the plugin occupies 1 line only, but the icon shrinks very much.

Did you use another icon? Could you please try with the current version from Git?
Comment 3 Fabian Nowak editbugs 2016-05-29 21:29:48 CEST
(In reply to Jesús Guerrero Botella from comment #1)
> Created attachment 6099 
> Patch to force the call of mounter_set_size()

Which size did you use for a panel plugin's line? 24 pixels?
Comment 4 Jesús Guerrero Botella 2016-06-04 11:08:15 CEST
Hi and sorry for the delay. 

I didn't get the time to look into this until this morning.

I re-installed the plugin and added it to my panel, my configuration didn't change much since last year. However, right now I can't reproduce this odd behavior.

I think there might have been a couple updates to xfce4-panel and some of the libs since then (the plugin version is the same).

The three rows layout definitely is the same I was using last year, so...

I will leave the plugin setting there for a few days and try to play a bit with it to see if I can reproduce this. But it smells like the problem was somewhere else even though it showed in this plugin.

If I can find something I'll report back, in the while I think you can just close the bug.

Thanks for taking a look in to this.

Bug #11728

Reported by:
Jesús Guerrero Botella
Reported on: 2015-03-20
Last modified on: 2020-05-21

People

Assignee:
Fabian Nowak
CC List:
1 user

Version

Version:
unspecified

Attachments

Screenshot showing the problem (300.87 KB, image/jpeg)
2015-03-20 11:58 CET , Jesús Guerrero Botella
no flags
Patch to force the call of mounter_set_size() (577 bytes, patch)
2015-03-20 11:59 CET , Jesús Guerrero Botella
no flags

Additional information