Created attachment 6097 
src/client.c and src/netwm.c fixes

I get the following warnings when compiling with clang and attached is a patch to quiet them.


  CC       xfwm4-client.o
client.c:1775:29: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
        if ((attr.map_state == IsUnmapped))
             ~~~~~~~~~~~~~~~^~~~~~~~~~~~~
client.c:1775:29: note: remove extraneous parentheses around the comparison to silence this warning
        if ((attr.map_state == IsUnmapped))
            ~               ^            ~
client.c:1775:29: note: use '=' to turn this equality comparison into an assignment
        if ((attr.map_state == IsUnmapped))
                            ^~
                            =
------------------------------------------------------------------------------------

  CC       xfwm4-netwm.o
netwm.c:192:27: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
            if ((atoms[i] == display_info->atoms[NET_WM_STATE_SHADED]))
                 ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netwm.c:192:27: note: remove extraneous parentheses around the comparison to silence this warning
            if ((atoms[i] == display_info->atoms[NET_WM_STATE_SHADED]))
                ~         ^                                          ~
netwm.c:192:27: note: use '=' to turn this equality comparison into an assignment
            if ((atoms[i] == display_info->atoms[NET_WM_STATE_SHADED]))
                          ^~
                          =
netwm.c:197:32: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_STICKY]))
                      ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netwm.c:197:32: note: remove extraneous parentheses around the comparison to silence this warning
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_STICKY]))
                     ~         ^                                          ~
netwm.c:197:32: note: use '=' to turn this equality comparison into an assignment
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_STICKY]))
                               ^~
                               =
netwm.c:202:32: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_MAXIMIZED_HORZ]))
                      ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netwm.c:202:32: note: remove extraneous parentheses around the comparison to silence this warning
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_MAXIMIZED_HORZ]))
                     ~         ^                                                  ~
netwm.c:202:32: note: use '=' to turn this equality comparison into an assignment
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_MAXIMIZED_HORZ]))
                               ^~
                               =
netwm.c:207:32: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_MAXIMIZED_VERT]))
                      ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netwm.c:207:32: note: remove extraneous parentheses around the comparison to silence this warning
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_MAXIMIZED_VERT]))
                     ~         ^                                                  ~
netwm.c:207:32: note: use '=' to turn this equality comparison into an assignment
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_MAXIMIZED_VERT]))
                               ^~
                               =
netwm.c:212:32: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_FULLSCREEN]))
                      ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netwm.c:212:32: note: remove extraneous parentheses around the comparison to silence this warning
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_FULLSCREEN]))
                     ~         ^                                              ~
netwm.c:212:32: note: use '=' to turn this equality comparison into an assignment
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_FULLSCREEN]))
                               ^~
                               =
netwm.c:220:32: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_ABOVE]))
                      ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netwm.c:220:32: note: remove extraneous parentheses around the comparison to silence this warning
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_ABOVE]))
                     ~         ^                                         ~
netwm.c:220:32: note: use '=' to turn this equality comparison into an assignment
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_ABOVE]))
                               ^~
                               =
netwm.c:228:32: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_BELOW]))
                      ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netwm.c:228:32: note: remove extraneous parentheses around the comparison to silence this warning
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_BELOW]))
                     ~         ^                                         ~
netwm.c:228:32: note: use '=' to turn this equality comparison into an assignment
            else if ((atoms[i] == display_info->atoms[NET_WM_STATE_BELOW]))
                               ^~
                               =
------------------------------------------------------------------------------------