Created attachment 6093 Screenshot showing issue I would like to inform, that pulseaudio-plugin starting with 0.2.0 won't show any icons in the panel. Running Fedora 20 with Stock GTK+ / Gnome Icons (which are the default icons installed) will not show any icons, once you add pulseaudio-plugin 0.2.0 (and 0.2.1) on the panel. All you can see is an empty button. Nothing more. Installing some different icon themes will make icon appear. Also installing gnome-symbolic icon theme will show an icon (most likely only unicolored one: please have a look at one of my other bugreports and attached screenshots). pulseaudio-plugin 0.1.0 shows icon properly. The icon also moves (changes), once you change themes. Have a try with stock icons and no theming. I have tried 0.2.0 from xfce4.12 copr and even compiled 0.2.1 on my own and tried again. Either an icon is missing or something magically changed.
I spent some time today to investigate into this and then reminded myself that this plugin is GTK3 based. Earlier I saw that the stock icons got replaced by the symbolic ones (which I don't have installed). I could install them and get the symbolic svg icons but still. It doesn't feel right. I asked myelf whether the symbolic status icons (unicolored) are right. And yes in the context of GTK3 and notification area they might (Like on phones where you have unicolored wifi, G3 indicator, sound, etc.). In the context of a panel plugin inside XFCE where most (if not all) other plugins use colored stock icons it feels wrong. For me I came up with a small patch, reverting the symbolic icons with stock icons. But still leaves one symbolic icon remaining. Even when removing that plugin I figured out that the "Information" Icon looks differently to those shown by other plugins. Is there anything that can be done to improve the user experience here ? I don't mind if this is a GTK3 plugin, but it should feel and behave similar to other plugins.
Seems like a packaging/dependency issue in the Fedora package. It may be worth reporting downstream. The plugin uses Gtk3 because when I started working on it there was a firm plan to port the panel to Gtk3 as well and I didn't feel I want to implement the plugin twice. The result is that for a while it will remain inconsistent with the current Gtk2 panel.
Created attachment 6095 Revert from symbolic to stock Well it wasn't an downstream issue. After all the question why symbolic icons has been chosen over stock icons, is still left unanswered. The plugin looks a bit *foreign* compared to all the other plugins that use stock icons. Are there plans to move all plugins to symbolic icons ? I came up with a patch that reverted from symbolic icons back to stock icons. I saw in the pulseaudio-menu.c file that for the other icon ... GTK_ICON_LOOKUP_GENERIC_FALLBACK ... is used. I assume this loads stock icons, if it's inable to find the symbolic ones. Maybe this can be applied to the volume icons as well ? I ask this, because if I install the symbolic icons-package, then the menu shows a symbolic icon, if I remove the symbolic icons-package again then it falls back using a stock one. Line 291 in pulseaudio-buttons.c would it work to change GTK_ICON_LOOKUP_USE_BUILTIN to GTK_ICON_LOOKUP_GENERIC_FALLBACK ?
Created attachment 6096 A different approach I just tested what I wrote with changing the GTK+ Attributes. This at least matches the way how pulseaudio-menu.c deals with icons if it doesn't find the symbolic ones. It strips to the name before the "-" symbol and tries the stock (real) icon first.