! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
fix the default wallpaper folder
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfdesktop
Component:
General

Comments

Description HJ 2015-03-17 19:39:47 CET
Hi,

the content of default wallpaper folder should be displayed always, since evertime i choose an image from another folder i need to manually enter/search the default wallpaper folder again.

Also even better would be to to copy a choosed wallpaper into the the default wallpaper folder.
Comment 1 Julien [nodiscc] editbugs 2015-03-23 23:27:28 CET
Hi JK, the contents of the default wallpaper directory (/usr/share/backgrounds/xfce/ on my distro) are always displayed for me. When I open the wallpaper selection dialog, I always see the default xfce-blue.jpg wallpaper listed.

This isn't the case for you? WHat distribution/xfdesktop version?
Comment 2 Thaddaeus Tintenfisch editbugs 2015-03-24 09:12:49 CET
Created attachment 6120 
Add default wallpaper folder to file chooser

This simple patch adds the entry "backgrounds" (/usr/share/backgrounds) to the file chooser dialog window and drop down menu.
Comment 3 Olivier Duchateau 2015-03-25 16:07:51 CET
Created attachment 6123 
Don't hard code default wallpaper folder

The previous patch works only on system where PREFIX is /usr (usually Linux). On BSD systems PREFIX is different, so default wallpaper folder is not found.

Patch fixes this issue.
Comment 4 Olivier Duchateau 2015-03-25 16:24:35 CET
Created attachment 6124 
Don't hard code default wallpaper folder

New patch, respect default tab/space.
Comment 5 Thaddaeus Tintenfisch editbugs 2015-03-26 11:57:52 CET
Olivier, your patch changes the wallpaper location to PREFIX/share/xfce4/backdrops. Is this intended?
Comment 6 Olivier Duchateau 2015-03-26 18:31:38 CET
(In reply to Thaddaeus Tintenfisch from comment #5)
> Olivier, your patch changes the wallpaper location to
> PREFIX/share/xfce4/backdrops. Is this intended?

No, it's mistake, I tested when directory doesn't exist, and I forgot to replace the right name, Sorry.

I send patch to Eric.
Comment 7 Thaddaeus Tintenfisch editbugs 2015-03-29 23:57:57 CEST
HJ, any comment on the proposed solution?
Comment 8 HJ 2015-03-30 15:36:32 CEST
yup that last one works for me
Comment 9 Thaddaeus Tintenfisch editbugs 2015-04-06 21:06:10 CEST
Marking as fixed.

Last commit for reference:

http://git.xfce.org/xfce/xfdesktop/commit/?id=8afa95fde4afb2150e342e5cef2c55c2cbb7528e

Bug #11715

Reported by:
HJ
Reported on: 2015-03-17
Last modified on: 2015-04-06

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Version:
4.12.0

Attachments

Add default wallpaper folder to file chooser (1005 bytes, patch)
2015-03-24 09:12 CET , Thaddaeus Tintenfisch
no flags
Don't hard code default wallpaper folder (2.51 KB, patch)
2015-03-25 16:07 CET , Olivier Duchateau
no flags
Don't hard code default wallpaper folder (2.60 KB, patch)
2015-03-25 16:24 CET , Olivier Duchateau
no flags

Additional information