! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Workspace Switcher uses wrong aspect ratio with Compiz
Status:
RESOLVED: MOVED
Product:
Xfce4-panel
Component:
Workspace Switcher

Comments

Description Huw Rogers 2015-03-13 03:06:58 CET
Created attachment 6076 
patch

This bug is originally submitted here: https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/1292820 by Cedric Dufour. Patch is also his.

1. the pager does not use the 'wnck_workspace_get_{width,height}' to calculate its aspect ratio
2. the pager does not recalculate its aspect ratio when Compiz workspaces/viewports settings are changed

Please consider attached patch to fix this behavior.
Once applied, pager size is correct for both Compiz and XFWM4.
Comment 1 Huw Rogers 2015-09-02 01:55:43 CEST
bump!
Comment 2 Charles Bos 2015-09-05 13:22:55 CEST
Created attachment 6447 
Panel switcher screenshot (wrong aspect ratio)
Comment 3 Charles Bos 2015-09-05 13:25:13 CEST
Created attachment 6448 
Panel switcher screenshot (correct aspect ratio)
Comment 4 Charles Bos 2015-09-05 13:26:24 CEST
I've not got much to say other than that this affects me too - Arch Linux, Compiz 0.9.12, Xfce 4.12. To illustrate the problem, I've attached a couple of screenshots.
Comment 5 Charles Bos 2015-09-05 16:55:26 CEST
Attached patch works here on Arch as well.
Comment 6 Michael Kogan 2019-08-24 11:12:01 CEST
The patch is not compatible with Xfce 4.14 any more, is there somebody knowledgeable enough to look into it and check if it can be modified to work with the new Xfce?
Comment 7 Erik-Jan 2019-09-05 17:36:33 CEST
Created attachment 9004 
fix pager size for compiz viewports

Here's an updated patch for xfce4-panel-4.14.
When applying, it can give some 'offset xxx lines' notices but that shouldn't be a problem.
Comment 8 Michael Kogan 2019-09-06 10:44:25 CEST
Thanks, works perfectly!
Comment 9 Git Bot editbugs 2020-05-28 01:55:34 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/119.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #11697

Reported by:
Huw Rogers
Reported on: 2015-03-13
Last modified on: 2020-05-28

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
4.12.0

Attachments

patch (2.78 KB, text/plain)
2015-03-13 03:06 CET , Huw Rogers
no flags
Panel switcher screenshot (wrong aspect ratio) (1.14 KB, image/png)
2015-09-05 13:22 CEST , Charles Bos
no flags
Panel switcher screenshot (correct aspect ratio) (2.04 KB, image/png)
2015-09-05 13:25 CEST , Charles Bos
no flags
fix pager size for compiz viewports (2.96 KB, patch)
2019-09-05 17:36 CEST , Erik-Jan
no flags

Additional information