! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Recognize other menu editors
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Applications Menu

Comments

Description ToZ editbugs 2015-03-11 16:18:03 CET
Currently, the Applications Menu Properties dialog only shows the "Edit Menu" option if alacarte is installed. There are other menu editors (e.g. menulibre) that could also be recognized to display the "Edit Menu" button.

Workaround: "sudo ln -s /usr/bin/menulibre /usr/local/bin/alacarte" allows the "Edit Menu" button to display and launches menulibre.
Comment 1 ToZ editbugs 2015-03-13 00:47:19 CET
Created attachment 6074 
patch to recognize more menu editors

Please find attached a patch (my first ever patch - yeah me!) to allow for the recognition of multiple menu editors. It removes the hard-coded alacarte option and iterates through a list of 4 (alacarte, menulibre, lxmed, xame) and uses the first one that it encounters.
Comment 2 ToZ editbugs 2015-03-13 00:54:25 CET
Created attachment 6075 
patch to recognize more menu editors (2nd try)

Newbie alert! I think I did the last patch wrong. Here's a version using "git diff -p".
Comment 3 ToZ editbugs 2015-03-21 13:37:00 CET
Created attachment 6105 
patch to recognize more menu editors (version 3)

Here is a newer (and hopefully better) version of the patch. This one removes the hard-coding of alacarte from the applications_menu_plugin_configure_plugin function and sets it as the default editor via a #define statement. This patch also exposes a "menu-editor" xfconf entry that can be created to specify another menu-editor and uses that editor instead if specified.
Comment 4 Git Bot editbugs 2018-12-04 20:34:47 CET
Tony Paulic referenced this bugreport in commit 1d981213f29558246b31134b23c3e4df037be276

appmenu: Add support for other menu editors (Bug #11684)

https://git.xfce.org/xfce/xfce4-panel/commit?id=1d981213f29558246b31134b23c3e4df037be276
Comment 5 Simon Steinbeiss editbugs 2018-12-04 20:36:16 CET
Took a bit, but I pushed your patch. Only omitted a commented line, some empty newline and a useless exo_str_is_empty check (because you set the fallback value further up in the code already).

I also set MenuLibre as the new default editor, haven't seen or used alacarte in ages (is it actually still around..?)

Bug #11684

Reported by:
ToZ
Reported on: 2015-03-11
Last modified on: 2018-12-04

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
Unspecified

Attachments

Additional information