! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
ristretto-0.8.0 appdata fails validation
Status:
RESOLVED: FIXED
Product:
Ristretto
Component:
Application

Comments

Description Kevin Fenzi 2015-03-01 18:23:07 CET
When running: 

appstream-util validate-relax --nonet /usr/share/appdata/ristretto.appdata.xml

It fails with: 

FAILED:
? style-invalid         : <release> description should be prose and not contain hyperlinks [<p>This version comes with several changes such as online documentation on http://docs.xfce.org, the option to limit the maximum image-quality to the screen dimensions to improve memory-usage and performance - now ristretto renders at full quality with this option disabled, only one toolbar - instead of two, a quick-launch button on the toolbar to execute an editor, the option to pick a default-editor per mime-type, an optional clock that shows up when ristretto is fullscreen, Ristretto now shows a 'Loading..' message in the statusbar to indicate when it is busy and progressive loading of directories to prevent lockup of the UI. This version is designed to work with version 4.10 of Xfce.</p>]
? style-invalid         : <p> cannot contain a hyperlink [This version comes with several changes such as online documentation on http://docs.xfce.org, the option to limit the maximum image-quality to the screen dimensions to improve memory-usage and performance - now ristretto renders at full quality with this option disabled, only one toolbar - instead of two, a quick-launch button on the toolbar to execute an editor, the option to pick a default-editor per mime-type, an optional clock that shows up when ristretto is fullscreen, Ristretto now shows a 'Loading..' message in the statusbar to indicate when it is busy and progressive loading of directories to prevent lockup of the UI. This version is designed to work with version 4.10 of Xfce.]
Validation of files failed
Comment 1 Kevin Fenzi 2015-03-01 19:47:29 CET
The entire thing it seems to be complaining about is the http link to docs.xfce.org... 
Just removing this seems to make it happy: 

diff -Nur ristretto-0.8.0.orig/ristretto.appdata.xml.in ristretto-0.8.0/ristretto.appdata.xml.in
--- ristretto-0.8.0.orig/ristretto.appdata.xml.in	2015-01-25 01:10:20.000000000 -0700
+++ ristretto-0.8.0/ristretto.appdata.xml.in	2015-03-01 11:45:00.576605438 -0700
@@ -66,7 +66,7 @@
     <release version="0.6.0" timestamp="1335662454">
       <description>
         <_p>This version comes with several changes such as online documentation on
-           http://docs.xfce.org, the option to limit the maximum image-quality to
+           docs.xfce.org, the option to limit the maximum image-quality to
            the screen dimensions to improve memory-usage and performance - now ristretto
            renders at full quality with this option disabled, only one toolbar - instead 
            of two, a quick-launch button on the toolbar to execute an editor, the option
Comment 2 Eric Koegel editbugs 2015-03-02 13:54:27 CET
Ah, I didn't know there was an appstream-util. Thank you.
Pushed your patch to master:
commit 3ae341ba0bbf5c0fefcdb02a3674061a6b73f7db
Author: Kevin Fenzi <kevin@scrye.com>
Date:   Mon Mar 2 15:41:11 2015 +0300

    appdata fails validation (Bug #11622)
    
    appstream-util fails with "cannot contain a hyperlink".
    
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
http://git.xfce.org/apps/ristretto/commit/?id=3ae341ba0bbf5c0fefcdb02a3674061a6b73f7db

Bug #11622

Reported by:
Kevin Fenzi
Reported on: 2015-03-01
Last modified on: 2015-03-02

People

Assignee:
Stephan Arts
CC List:
2 users

Version

Version:
master

Attachments

Additional information