Coming from Thunar 1.4, i liked in entries in the side pane ordered as places and devices and it would be great if it was possible to sort it that way with an option in preferences in the side pane tab.
It should be relatively easy to make an xfconf hidden key for this, albeit I'm not sure the feature is worth the extra code to maintain. Jay, what is the benefit for you of having this specific sorting? Is it a big deal in your day to day use?
Hi Steve, I use thunar on the Cinammon desktop environments rather than their default file manager Nemo, but unfortunately i cant avoid having to use Nemo at some instances (e.g. clicking on the folder on the desktop) and its view is like that and so was Thunar 1.4. I feel that it is a better order as the items you would use less would be sorted below, the same way that it is in tree view. And i switch between the two quite often.
@alex, @theo: what do you guys link of this?
Was reading a review and it mentioned 'Devices shown before home folders; no way to rearrange.'. https://www.dedoimedo.com/computers/xubuntu-cosmic.html Thunar is the only file manager that puts Devices before Places and it would be good to arrange it according to importance and this would also make the arrangement the same as it is in tree view and also in the 'save as' dialog which hides all devices and network items underneath the '+ other locations' entry. https://imgur.com/JlZgauh.png
> arrange it according to importance What is important and what not may differ from on user to another. IMO the best solution would be to be able to reorder device and Places by drag and drop. Like it is already possible for bookmarks. The order should be kept in some xfconf setting.
https://www.dedoimedo.com/images/computers-years/2018-2/xubuntu-cosmic-file-manager-icons.png Looking at this screenshot I agree that Places should be listed first so that it stays visible even when many devices are connected.
(In reply to Theo Linkspfeifer from comment #6) > https://www.dedoimedo.com/images/computers-years/2018-2/xubuntu-cosmic-file- > manager-icons.png > > Looking at this screenshot I agree that Places should be listed first so > that it stays visible even when many devices are connected. Ok, that's a fair reason. Sorry, I guess I was wrong. So yes, would be ok for me to have a xfconf hidden key for it. Think we could have "places above devices" as the default.
Created attachment 9546 places above devices
Yousuf Philips referenced this bugreport in commit 0e9f6d096dae8805390eca509b1d8384ca9f42d4 Move places above devices in shortcuts view (bug #11586) https://git.xfce.org/xfce/thunar/commit?id=0e9f6d096dae8805390eca509b1d8384ca9f42d4
pushed to master. Thank you for your contribution !
Created attachment 9552 Restore previous order within Devices group in shortcuts view I think that the "File System" entry should stay at the top of its group because it is / (root) and should be easily accessible even with many mounts/volumes present (see linked screenshot in comment #6).
(In reply to Theo Linkspfeifer from comment #11) > Created attachment 9552 > Restore previous order within Devices group in shortcuts view > > I think that the "File System" entry should stay at the top of its group > because it is / (root) and should be easily accessible even with many > mounts/volumes present (see linked screenshot in comment #6). Agreed .. I did not think about that one. I will as well move trash back to its original place ... if it should be moved, we need to talk about it first. (Sorry, I was to fast with applying the patch)
Theo Linkspfeifer referenced this bugreport in commit bc59edee16b48f6674cd4092ecf0ea14b78092ac Restore previous order of subitems in shortcuts view (Bug #11586) https://git.xfce.org/xfce/thunar/commit?id=bc59edee16b48f6674cd4092ecf0ea14b78092ac
(In reply to alexxcons from comment #12) > Agreed .. I did not think about that one. Here was the irc discussion we had about it. brainwash> jphilips: I didn't notice it yesterday.. but why where Trash and Files System moved down inside their groups? <jphilips> brainwash: its there in the commit. to unify their position with tree view <brainwash> I suggest to move at least file system up again <brainwash> it should be on position 1 <jphilips> what is the argument behind that <brainwash> it's part of the system you use <brainwash> the reason why it is at the bottom in tree view is that it functions as last node <brainwash> find last node -> put mounts/volumes above it <brainwash> this could be changed, but the original author did it this way <jphilips> my reasoning for it, in addition to unifying it with tree view, is that the order should be sorted by what is most used. it is more likely that a user would access their partitions and plugged in usb drive or phone over access the root file system <brainwash> but if you have plenty of devices, they will move the file system entry even further down <brainwash> we already moved the whole group down <brainwash> I mean you didn't network above devices, right? <brainwash> despite that being the case in tree view <jphilips> network is an entire group <brainwash> network group about devices group <jphilips> i plan to move network down in tree view <brainwash> above <jphilips> less people access the network than devices <brainwash> but then you most likely will move mounts/volumes below file system too <jphilips> we seem to be misunderstanding each other. i plan to move network after file system in tree view, so its unified with shortcut view <brainwash> I simply don't like that <brainwash> why not move it up to places? <jphilips> move network up to places? <brainwash> file system <jphilips> seems reasonable to be at the bottom of places in shortcut view, but what are your thoughts of why it was put at the top of devices <brainwash> because it is / <brainwash> (root) <brainwash> or you mean why at all? <jphilips> i meant why at all, as do you consider root a device and if so, then it would more logically have to stay under devices <brainwash> jphilips: I want easy access to File System <brainwash> and it not being pushed down so that I have to scroll down <brainwash> it used to be at the very top of the side pane <brainwash> not anymore <jphilips> so i presume you have alot of devices <brainwash> I'm aware that Computer -> File System <brainwash> but that is two clicks <brainwash> you don't even need that many devices, just a smaller window <jphilips> at 1/4th my screen resolution, i only see places, so i would need to scroll to get to anything below it <jphilips> i'm at 1440x900 <brainwash> time to link this one again https://www.dedoimedo.com/images/computers-years/2018-2/xubuntu-cosmic-file-manager-icons.png <jphilips> as you said, its more important for you to have file system at the top, and i believe its better it to be at the bottom, i guess we can leave it to alexxcons to do be the tie breaker <jphilips> or the middle ground of it being at the bottom of places > I will as well move trash back to its original place ... if it should be > moved, we need to talk about it first. > (Sorry, I was to fast with applying the patch) Sorry i thought you would have read the commit message. About trash, should the discussion happen here or in another bug report.
(In reply to Jay Philips from comment #14) > Here was the irc discussion we had about it ... Yea, I read it ... just though it is sufficient to reply in the bug :) I tend to agree with Theo for the following reasons: - "Files System" usually is the most important device, so imo it should be on top - People with many devices may have to scroll to access "Files System" ... since it used to be on the very top before, it could make some people unhappy, to see it "degraded" that much (We now can access "Filesystem" via computer on top, which is good, though it takes longer travel to "Filesystem" via computer ) So I would rather fix the position in tree-view (as well "network" seems to need a position swap there) Regarding the Go-menu, I will take care. ... I just rebased my remove-gtkAction-etc--WIP branch against current master, to e.g as well include "computer" : https://imgur.com/v3sQzuV.png Here the branch: https://github.com/alexxcons/thunar/tree/MergeAllContextMenus6 > Sorry i thought you would have read the commit message. About trash, should > the discussion happen here or in another bug report. Yes, please open a new report for that. (Actually I read the message .. I should not drink beer and push patches at the same time :X )
(In reply to alexxcons from comment #15) > Yea, I read it ... just though it is sufficient to reply in the bug :) I > tend to agree with Theo for the following reasons: > - "Files System" usually is the most important device, so imo it should be > on top To the average user it isnt the most important device. They wont understand or touch File System, especially when it requires root access to change things. You can check for example the 'Open' or 'Save As' dialog, which hides all devices group entries under 'Other Locations' and calls it 'Computer' rather than 'File System'. > - People with many devices may have to scroll to access "Files System" ... > since it used to be on the very top before, it could make some people > unhappy, to see it "degraded" that much (We now can access "Filesystem" via > computer on top, which is good, though it takes longer travel to > "Filesystem" via computer ) Unfortunately we cant please everyone with any change we make, thats why we have so many xfconfig settings i guess :D, but the changes should be what is best for most users. Here are how other file managers handle root in the shortcuts pane Caja: Located in 3rd underneath home and Desktop and before home's other child folders Nemo: Bottom of group above Trash Nautilus: Similar to file dialogs ( Other Locations > Computer ) PCManFM: Not accessible PCMan-Qt: Accessible under Computer > File System > So I would rather fix the position in tree-view (as well "network" seems to > need a position swap there) Dont think this is a good idea as mentioned above, but if this is the final decision made for shortcut view, then ideally it should be unified with tree view. Network position bug filed (bug 16516) > Regarding the Go-menu, I will take care. ... I just rebased my > remove-gtkAction-etc--WIP branch against current master, to e.g as well > include "computer" : https://imgur.com/v3sQzuV.png Not sure what i'm seeing here, as the menu isnt open. > Yes, please open a new report for that. > (Actually I read the message .. I should not drink beer and push patches at > the same time :X ) bug 16515. :D
(In reply to Jay Philips from comment #16) > (In reply to alexxcons from comment #15) > > Yea, I read it ... just though it is sufficient to reply in the bug :) I > > tend to agree with Theo for the following reasons: > > - "Files System" usually is the most important device, so imo it should be > > on top > > To the average user it isnt the most important device. They wont understand > or touch File System, especially when it requires root access to change > things. You can check for example the 'Open' or 'Save As' dialog, which > hides all devices group entries under 'Other Locations' and calls it > 'Computer' rather than 'File System'. I agree that the average user might rather use e.g. removable media, though "File System" is the root of everything. Because of that, imo, if it is displayed, it belongs to the top. How about we just hide it per default ? > > > - People with many devices may have to scroll to access "Files System" ... > > since it used to be on the very top before, it could make some people > > unhappy, to see it "degraded" that much (We now can access "Filesystem" via > > computer on top, which is good, though it takes longer travel to > > "Filesystem" via computer ) > > Unfortunately we cant please everyone with any change we make, thats why we > have so many xfconfig settings i guess :D, but the changes should be what is > best for most users. Here are how other file managers handle root in the > shortcuts pane > > Caja: Located in 3rd underneath home and Desktop and before home's other > child folders > Nemo: Bottom of group above Trash > Nautilus: Similar to file dialogs ( Other Locations > Computer ) > PCManFM: Not accessible > PCMan-Qt: Accessible under Computer > File System > > > So I would rather fix the position in tree-view (as well "network" seems to > > need a position swap there) > > Dont think this is a good idea as mentioned above, but if this is the final > decision made for shortcut view, then ideally it should be unified with tree > view. So each file-manager does it in a different way :) Actually I think arguments like "thats the correct order" are always a matter of taste/habbit. I would prefer to have the possibility to drag and drop devices, like already possible for bookmarks. (same as dolphin) ... so everybody can freely order them. > > Regarding the Go-menu, I will take care. ... I just rebased my > > remove-gtkAction-etc--WIP branch against current master, to e.g as well > > include "computer" : https://imgur.com/v3sQzuV.png > > Not sure what i'm seeing here, as the menu isnt open. Whoops, too slow ... this time: https://i.imgur.com/Cg4ZNLZ.png
(In reply to alexxcons from comment #17) > I agree that the average user might rather use e.g. removable media, though > "File System" is the root of everything. Because of that, imo, if it is > displayed, it belongs to the top. > How about we just hide it per default ? Yes technically according to the file system structure, 'File System' is the root of everything, but at the partition/device level, 'File System' is only the top level of the partition the system is running on and is on the same level as any other partition of the hard disk or removable media. I'd recommend to always show it by default, would likely piss off alot of power users if it ain't there, with an option to hide it. Even better is to have the option have 3 possible values - hidden, top, bottom. If such an option to hide it is there, then we'd also have to hide the Device group if there are no additional partitions or removable drives are currently listed (caja and nemo do this). > So each file-manager does it in a different way :) Actually I think > arguments like "thats the correct order" are always a matter of > taste/habbit. I would prefer to have the possibility to drag and drop > devices, like already possible for bookmarks. (same as dolphin) ... so > everybody can freely order them. Yep that kind of option would be great for a user's full customization. > Whoops, too slow ... this time: https://i.imgur.com/Cg4ZNLZ.png The order looks great, though Vorlagen likely should be removed from the menu and none of the devices and network shares are listed in it.
(In reply to Jay Philips from comment #18) > Yes technically according to the file system structure, 'File System' is the > root of everything, but at the partition/device level, 'File System' is only > the top level of the partition the system is running on and is on the same > level as any other partition of the hard disk or removable media. I'd > recommend to always show it by default, would likely piss off alot of power > users if it ain't there, with an option to hide it. Ok, I am as well not sure if it would be a good idea to hide it by default. Note that we already have the option to show/hide single devices, etc. in shortcut view on right click at the bottom. > Even better is to have > the option have 3 possible values - hidden, top, bottom. I dont like to have special treatment for specific devices (or places). If we want to have more options to position them, I would go for full DnD support, so that positions are freely configurable. > If such an option > to hide it is there, then we'd also have to hide the Device group if there > are no additional partitions or removable drives are currently listed (caja > and nemo do this). Already works fine here. If you hide all devices, the section "Devices" will as well vanish. (Though so far only available for shortcuts view) > > So each file-manager does it in a different way :) Actually I think > > arguments like "thats the correct order" are always a matter of > > taste/habbit. I would prefer to have the possibility to drag and drop > > devices, like already possible for bookmarks. (same as dolphin) ... so > > everybody can freely order them. > > Yep that kind of option would be great for a user's full customization. > > > Whoops, too slow ... this time: https://i.imgur.com/Cg4ZNLZ.png > > The order looks great, though Vorlagen likely should be removed from the > menu and none of the devices and network shares are listed in it. Actually I like to have "Vorlagen" at least somewhere .. even if that is a bit inconsistant :) ... I would rather add it to the shortcuts as well. Many users dont know that templates even exist, and the popup directly tells how it can be used. I agree regarding the network shares, though thats nothing I want to add during GtkAction replacement (what I originally wanted to do in that branch) .. we could look into that later on.
(In reply to alexxcons from comment #19) > Ok, I am as well not sure if it would be a good idea to hide it by default. > Note that we already have the option to show/hide single devices, etc. in > shortcut view on right click at the bottom. Yep I forgot about that. But as that is the case and you just have to right-click to make it visible again, I think that might be a good default. > Already works fine here. If you hide all devices, the section "Devices" will > as well vanish. (Though so far only available for shortcuts view) Forgot about that as i live in tree view. :D How easy would it be that if the device is hidden in shortcut view, it would also be hidden in tree view. > Actually I like to have "Vorlagen" at least somewhere .. even if that is a > bit inconsistant :) ... I would rather add it to the shortcuts as well. Many > users dont know that templates even exist, and the popup directly tells how > it can be used. Its right there when you first launch thunar in the folders pane. Adding it to shortcuts isnt good, as people barely open the folder. Never clicked on it before as I presumed it just went to the templates folder, but yes the dialog does give info and as its a dialog, the label should be 'Templates...'. > I agree regarding the network shares, though thats nothing I want to add > during GtkAction replacement (what I originally wanted to do in that branch) > .. we could look into that later on. Checked Nemo and Caja and they dont include it in the menu, so maybe its best to leave it static.
Created attachment 9568 Fix drop location check for bookmarks
Theo Linkspfeifer referenced this bugreport in commit dc7ec7139a9844784a103d7e013501348cef114e Fix drop location check for bookmarks (followup of bug #11586) https://git.xfce.org/xfce/thunar/commit?id=dc7ec7139a9844784a103d7e013501348cef114e
Thanks Theo ! Did not think about testing DnD :F