As reported on irc: < matt32_ > xfdesktop/src/gtkcairoblur.c:215: undefined reference to `cairo_surface_create_similar_image' cairo_surface_create_similar_image was added in cairo 1.12, and we list only cairo 1.6 as a requirement. first, i think that xfdesktop should check for cairo version in configure.ac if it directly uses cairo funcs.. and then, maybe it should use cairo_surface_create_similar instea there. http://cairographics.org/manual/cairo-cairo-surface-t.html#cairo-surface-create-similar http://cairographics.org/manual/cairo-cairo-surface-t.html#cairo-surface-create-similar-image looks like gthumb used cairo_image_surface_create instead here: https://mail.gnome.org/archives/commits-list/2012-August/msg06083.html note: ubuntu 12.04 uses cairo 1.10..
Note that this code was added in http://git.xfce.org/xfce/xfdesktop/commit/?id=010aea99483ae480a3328fa66e5c5768feda30d5
Well, The bug in any case was introduced here http://git.xfce.org/xfce/xfdesktop/commit/?id=7e8e8669606e662d1ee1e85815000f068f48acd9 And you has to revert first: * http://git.xfce.org/xfce/xfdesktop/commit/?id=2df1084704efaac8b625a943dc9e8c46a0b0cd0a * http://git.xfce.org/xfce/xfdesktop/commit/?id=9ac6329aa6451f261fc366901492eb002de8d62c And finally: * http://git.xfce.org/xfce/xfdesktop/commit/?id=010aea99483ae480a3328fa66e5c5768feda30d5 It's a shame but if you want to release xfce 4.12 with hurry instead of improving things, ok.. For 4.14 we will have time to do it right. Regards.
I never said things had to be *reverted* right now, rather fixed/improved to use cairo apis available in less recent versions...
It's OK!. Sorry if it sounded bad!. ;) I wrote those patches, but personally I have little free time and can not check it. Therefore if you want to reverse it, fine. Most people not know these changes, so it is not a significant change. If it causes problems, I prefer to reverse and do well later. ;) ps: Yes. I think we're in a hurry to release 4.12, but otherwise it's going to allow thinking then in 4.14, so it is perhaps welcome. I have mixed feelings about it. haha.
Created attachment 5976 Don't use cairo_surface_create_similar_image Oops, the buildbot noticed this before and I meant to fix it. Added the configure check and changed the function, let me know if you notice any regressions.
Thank you for the patch.
Fixed in 1255ded3ad7483588d879dd35d992a746b615335