! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
When renaming a file to go over the limit on properties dialog, it will not a...
Status:
RESOLVED: FIXED
Severity:
critical

Comments

Description Masato Hashimoto 2015-02-18 13:07:40 CET
Steps to Reproduce:
1. Open properties dialog for any file.
2. Rename it to too long name (over the limit of the length) on the dialog.
3. Error "File name too long" appears.

Actual result:
Error dialog appears forever repeatedly after clinking 'Close' button, so it cannot be canceled or re-rename.

Build & Platform:
Build 2015-02-18 on Arch Linux (x86_64)

Versions:
git-master
Comment 1 Steve Dodier-Lazaro editbugs 2015-02-19 11:46:00 CET
Hi Masato,

Thanks for your report, we'll look into it!

To whomever has time to patch: please remove the dialog altogether, and add a https://developer.gnome.org/gtk3/stable/GtkInfoBar.html to the UI (name it so it's obvious the bar should be used for filename_errors). Then, when you do your checks, simply show/hide it and apply pre-made strings for all the errors you plan on displaying:

"Filename too long"
"A file already exists with this name"
"Filename contains invalid characters (e.g. /)"

We gotta go through all of them since any other error dialog would equally steal focus and prevent the user from fixing her problem. Other problems like "name already exists" or "Filename contains /" are fairly frequent, hence the critical rating.
Comment 2 Harald Judt editbugs 2015-02-20 20:11:05 CET
Bug confirmed and fixed in http://git.xfce.org/xfce/thunar/commit/?id=2733416ce2ddc6118126a12f7c951830592b8f13.

Thanks for reporting.
Comment 3 Steve Dodier-Lazaro editbugs 2015-02-21 05:31:08 CET
Harald,

That's a much simpler fix :-) Kudos!

Bug #11557

Reported by:
Masato Hashimoto
Reported on: 2015-02-18
Last modified on: 2015-02-21

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
unspecified

Attachments

Additional information