! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix anchor offset, when Help button is clicked
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Thunar
Component:
Documentation

Comments

Description Olivier Duchateau 2015-02-17 21:14:49 CET 
Created attachment 5956 
Fix anchor in Help button

Fix link to documentation when link contains anchor.
Comment 1 Steve Dodier-Lazaro editbugs 2015-02-17 21:33:30 CET 
Thanks Olivier.

Could you please use the show_help_with_version instead? This should be used across Xfce from now on instead of the old version. See the Screenshooter for a working example.
Comment 2 Olivier Duchateau 2015-02-17 22:11:31 CET 
(In reply to Steve Dodier-Lazaro from comment #1)
> Thanks Olivier.
> 
> Could you please use the show_help_with_version instead? This should be used
> across Xfce from now on instead of the old version. See the Screenshooter
> for a working example.

I'm agree, but last time Landry rejected my patch [1], because xfce_dialog_show_help function calls xfce_dialog_show_help_with_version () in git (not in the latest release).

[1] https://bugzilla.xfce.org/show_bug.cgi?id=11480#c2
Comment 3 Simon Steinbeiss editbugs 2015-02-18 14:16:02 CET 
@Steve: I think that would be a separate patch to port *all* thunar help buttons to the new versioned docs-call.

This one is fairly low-hanging fruit and makes sense, so I went ahead and merged it: http://git.xfce.org/xfce/thunar/commit/?id=13cbeb761a6578acfcf6d710229fc2c9f075b5a1

Bug #11552

Reported by:
Olivier Duchateau
Reported on: 2015-02-17
Last modified on: 2015-02-18

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
unspecified
Target Milestone:
1.2.0

Attachments

Fix anchor in Help button (1.51 KB, patch)
2015-02-17 21:14 CET , Olivier Duchateau 		no flags

Additional information