Greetings. Trying to build xfce4-verve-plugin-1.0.1 with glib2-2.43.3 here and I get: ... verve-plugin.c: In function 'verve_plugin_load_completion': verve-plugin.c:110:5: warning: 'g_completion_add_items' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gcompletion.h:60) [-Wdeprecated-declarations] g_completion_add_items (verve->completion, items); ^ verve-plugin.c: In function 'verve_plugin_keypress_cb': verve-plugin.c:410:13: error: format not a string literal and no format arguments [-Werror=format-security] xfce_dialog_show_error (NULL, NULL, msg); ^ verve-plugin.c:454:9: warning: 'g_completion_complete' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gcompletion.h:68) [-Wdeprecated-declarations] similar = g_completion_complete (completion, prefix, NULL); ^ verve-plugin.c: In function 'verve_plugin_new': verve-plugin.c:516:3: warning: 'g_completion_new' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gcompletion.h:58) [-Wdeprecated-declarations] verve->completion = g_completion_new (NULL); ^ verve-plugin.c: In function 'verve_plugin_free': verve-plugin.c:568:3: warning: 'g_completion_free' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gcompletion.h:79) [-Wdeprecated-declarations] g_completion_free (verve->completion); ^ cc1: some warnings being treated as errors Makefile:543: recipe for target 'libverve_la-verve-plugin.lo' failed ... Happy to provide more info or test patches. Thanks.
I've fixed the -Werror=format-security one, but you should build with so many -Wfoo-bar, and mostly without -Werror. lots of xfce parts are not -Werror-clean... And gcompletion was deprecated without a viable replacement. thanks glib devs.
Err i meant you should *not* build with -Werror of course :) damn flu.
Well, fedora by policy builds with -Werror=format-security so people don't push builds that have broken format-security. ;) Anyhow, I can pick your commit from git... unless there's likely to be another release soon? Thanks for the quick fix.
Since the plugin now builds with -Werror=format-security, I'll mark this as fixed.