! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Subtitle fonts aren't previewed
Status:
RESOLVED: FIXED

Comments

Description andyourbirdisgreen 2015-01-07 01:31:19 CET
Created attachment 5849 
screenshot showing the list of fonts

I mean the list of fonts itself.
Comment 1 Simon Steinbeiss editbugs 2015-01-07 12:51:43 CET
Good catch, it should indeed show some preview text (which it currently doesn't). I'm not entirely sure what's up with that, either Gtk3 doesn't set a default preview text and we have to explicitely set it with gtk_font_chooser_set_preview_text or it's a bug in Gtk.
Comment 2 andyourbirdisgreen 2015-01-07 21:29:03 CET
(In reply to Simon Steinbeiss from comment #1)
> Good catch, it should indeed show some preview text (which it currently
> doesn't). I'm not entirely sure what's up with that, either Gtk3 doesn't set
> a default preview text and we have to explicitely set it with
> gtk_font_chooser_set_preview_text or it's a bug in Gtk.

I'm trying hard to remember where I saw that same font chooser with previews working.

Parole is minimal and great. It's just what I was looking for.

Thanks for listening (reading).
Comment 3 Simon Steinbeiss editbugs 2015-01-30 12:05:37 CET
Created attachment 5884 
Set the default subtitle font preview text

I have attached a trivial patch that fixes the issue. However, I'm not sure as to whether it is really a good choice to merge it, as it
1) introduces a new string for translators and
2) just covers up the fact that for some reason the default preview-text is empty.

(Note: The default preview-text is not supposed to be empty: https://developer.gnome.org/gtk3/stable/GtkFontChooser.html#GtkFontChooser--preview-text)
Comment 4 Simon Steinbeiss editbugs 2015-01-30 17:13:24 CET
Ok, found the culprit and the proper fix. (I suppose glade automatically added that property to our .ui file so it set the preview-text to "".)

Fixed in commit 5b1261537cce4579c17bf2959515eb989f7c550f.

Bug #11425

Reported by:
andyourbirdisgreen
Reported on: 2015-01-07
Last modified on: 2015-01-30

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Attachments

screenshot showing the list of fonts (235.51 KB, image/png)
2015-01-07 01:31 CET , andyourbirdisgreen
no flags
Set the default subtitle font preview text (1.06 KB, patch)
2015-01-30 12:05 CET , Simon Steinbeiss
no flags

Additional information