! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Panel hides when menus are open with intelligent hiding
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Simon Steinbeiss editbugs 2014-12-06 19:37:48 CET
Created attachment 5803 
Fix intelligent hiding with open menus

When opening e.g. the calendar of the internal clock-plugin of the panel, it currently hides with intelligent hiding enabled.
The patch attached should fix these problems.
Comment 1 Simon Steinbeiss editbugs 2014-12-06 21:22:20 CET
FWIW this patch doesn't work with e.g. the datetime plugin, but this is the plugin's fault. You can easily test by opening the plugin's properties dialog which correctly blocks the panel from autohiding by calling xfce_panel_plugin_block_menu and xfce_panel_plugin_unblock_menu.

This call should also be added in pop_calendar_window and close_calendar_window here:
http://git.xfce.org/panel-plugins/xfce4-datetime-plugin/tree/panel-plugin/datetime.c#n257
Comment 2 Simon Steinbeiss editbugs 2014-12-07 00:07:50 CET
Created attachment 5805 
Updated patch to fix hiding of menus with intelligent hiding

Dropped the erroneous check for BLOCKED state from the thaw function and attached the new patch.
Comment 3 Simon Steinbeiss editbugs 2014-12-07 00:18:14 CET
Created attachment 5806 
Fix intelligent hiding of the panels with open menus

Updated commit-message to reference bug number.
Comment 4 Simon Steinbeiss editbugs 2014-12-07 00:23:55 CET
This bug was fixed in master in commit http://git.xfce.org/xfce/xfce4-panel/commit/?id=3c995cac169657e24409849d33e7adca2ce28cfe

Bug #11358

Reported by:
Simon Steinbeiss
Reported on: 2014-12-06
Last modified on: 2014-12-07

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information