! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
systemload has broken tooltip
Status:
RESOLVED: FIXED
Product:
Xfce4-systemload-plugin
Component:
General

Comments

Description Daniel Kessel 2014-11-19 23:42:05 CET
Created attachment 5758 
screenshot of the broken tooltip with the german translation.

The plugin's tooltip is broken. I am using the german translation. It shows the hours and minutes. Yet the tooltip says (translated back to english) "3 days 44:-1079634504". So it is not only using the wrong units, but also displaying this large negative number instead of something meaningful.

I am using xfce4-systemload-plugin in version 1.1.1 from the normal ubuntu package sources.
Comment 1 Landry Breuil editbugs 2014-11-19 23:57:52 CET
I think that's not the xfce4-systemload panel plugin, but rather the systray icon of a minimized xfce4-taskmanager....at least that's what the icon tells me.
Or is it only the 'uptime' monitor of the systemload plugin (the small 3:44 on the left ?) ? are other monitors showing weird too ?
Comment 2 Daniel Kessel 2014-11-20 00:00:19 CET
Yes, only the left part if the systemload-plugin... "3:44".
Comment 3 Landry Breuil editbugs 2014-11-20 00:09:52 CET
aha. so maybe something is handled wrong in the translation string :

http://git.xfce.org/panel-plugins/xfce4-systemload-plugin/tree/po/de.po#n54

is the string used for de when the uptime is in days... is your uptime more than a day when the bug occurs ?
Otherwise, that might be a counter overflowing somewhere.. can you check only the german translation shows this ? on which architecture, 32 or 64 bits ?
Comment 4 Daniel Kessel 2014-11-20 22:06:25 CET
This happens when the uptime is less than one day - in both 32 bit and 64 bit. In the english translation, the string is correct.

The german version should use this string instead:
http://git.xfce.org/panel-plugins/xfce4-systemload-plugin/tree/po/de.po#n62

It correctly shows http://git.xfce.org/panel-plugins/xfce4-systemload-plugin/tree/po/de.po#n61 in english...
Comment 5 Landry Breuil editbugs 2014-11-20 23:11:41 CET
Ok, so after some head scratching, found the source of the issue.. 1.1.1 ships with http://git.xfce.org/panel-plugins/xfce4-systemload-plugin/tree/po/de.po?id=1.1.1#n63, where msgid contains two variables, and msgstr expects 3, and thus displays garbage for the last one. Probably a copypaste from the previous msgid.. since this is fixed in master, i'll make a bugfix/translation release in some days.
Comment 6 Raphael Groner 2014-11-21 02:52:52 CET
Confirmed.

The label says "15:43" and the tooltip shows "15 Tag 43:127".

$ uptime
 02:45:30 up 15:43,  4 users,  load average: 1,22, 1,21, 1,23
$ cat /proc/uptime 
56617.08 204598.59

I guess this is no translation bug but seems more like an issue with fscanf:
http://git.xfce.org/panel-plugins/xfce4-systemload-plugin/tree/panel-plugin/uptime.c#n56

xfce4-systemload-plugin-1.1.1-4.fc20.x86_64
kernel 3.17.2
Comment 7 Landry Breuil editbugs 2014-11-21 10:03:49 CET
(In reply to Raphael Groner from comment #6)
> Confirmed.
> 
> The label says "15:43" and the tooltip shows "15 Tag 43:127".
> 
> $ uptime
>  02:45:30 up 15:43,  4 users,  load average: 1,22, 1,21, 1,23
> $ cat /proc/uptime 
> 56617.08 204598.59
> 
> I guess this is no translation bug but seems more like an issue with fscanf:
> http://git.xfce.org/panel-plugins/xfce4-systemload-plugin/tree/panel-plugin/
> uptime.c#n56

No, this is an issue with the translation that was shipped in 1.1.1, see my previous comment :)
Should be fixed in the just-released 1.1.2.

Bug #11316

Reported by:
Daniel Kessel
Reported on: 2014-11-19
Last modified on: 2014-11-21

People

Assignee:
Florian Rivoal
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information