! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Basic LightDM and light-locker support for xflock4
Status:
RESOLVED: WONTFIX
Severity:
enhancement
Product:
Xfce4-session
Component:
General

Comments

Description Rob McCathie 2014-10-27 09:23:15 CET
Created attachment 5709 
add lightdm and light-locker support

I'm aware of this bug report:
https://bugzilla.xfce.org/show_bug.cgi?id=10217

But it's scope is much larger than my proposal. This request is just for basic support for lightdm's built-in dm-tool and optional light-locker daemon.
Comment 1 Yves-Alexis Perez editbugs 2014-11-04 22:11:13 CET
dm-tool lock is not safe, it'll actually just switch to the greeter, and won't report back if nothing locked the screen.
Comment 2 Rob McCathie 2014-11-05 01:54:03 CET
@Yves-Alexis Perez (Comment 1):

I know. I'm not saying it's good, i'm asking for xflock4 to support it, not pass judgement on it.

Anyways if it's considered an issue to the point where it's not acceptable for commit, can we at least get just the light-locker support?

I'm already running this patch in Manjaro's xfce4-session manager package (in Unstable and Testing branches) and we are shipping LightDM+light-locker on the upcoming installation media.

It's plenty easy for us to just keep patching it in, would just be nice if it be accepted here upstream.
Comment 3 Yves-Alexis Perez editbugs 2014-11-05 08:47:54 CET
(In reply to Rob McCathie from comment #2)
> @Yves-Alexis Perez (Comment 1):
> 
> I know. I'm not saying it's good, i'm asking for xflock4 to support it, not
> pass judgement on it.

The thing is, I don't think it should be used at all. The whole point of xflock4 is to lock the screen (or return an error if it can't). You can't know who will call xflock4 and wether it's safe or not to not lock and don't return an issue.

That's why I think dm-tool lock should not be used in a script, but only directly called by an user.
Comment 4 Rob McCathie 2014-11-05 13:52:26 CET
(In reply to Yves-Alexis Perez from comment #3)
> (In reply to Rob McCathie from comment #2)
> > @Yves-Alexis Perez (Comment 1):
> > 
> > I know. I'm not saying it's good, i'm asking for xflock4 to support it, not
> > pass judgement on it.
> 
> The thing is, I don't think it should be used at all. The whole point of
> xflock4 is to lock the screen (or return an error if it can't). You can't
> know who will call xflock4 and wether it's safe or not to not lock and don't
> return an issue.
> 
> That's why I think dm-tool lock should not be used in a script, but only
> directly called by an user.

Ok, so, how about just light-locker? (the first hunk of the patch only).
Comment 5 Raphael Groner 2014-11-22 17:13:53 CET
See also bug #11324.
Comment 6 Christian Hesse 2018-12-29 23:31:17 CET
Any news on this one? It is more than four years old now...
Comment 7 Simon Steinbeiss editbugs 2019-04-28 00:29:08 CEST
@Christian Hesse: This bug is obsolete as any distribution can set their default locker easily by setting the /general/LockCommand property in the xfce4-session channel of xfconf (it's integrated in xflock4).
Users who switch to a different lockscreen can consequently also easily fix this. It's arguably not a very discoverable feature, but changing the default lockscreen of a distribution is also not a very every-day "normal" operation imo.

The main reason - from my point of view - xflock4 was still extended by distros with patches was because they had a default locker that was not in the list.
Comment 8 Theo Linkspfeifer editbugs 2019-06-19 18:10:11 CEST
*** Bug 12415 has been marked as a duplicate of this bug. ***
Comment 9 Sergio 2019-06-19 22:07:06 CEST
The command to lock the screen is

light-locker-command -l

Bug #11254

Reported by:
Rob McCathie
Reported on: 2014-10-27
Last modified on: 2020-01-07
Duplicates (1):
  • 12415 xflock4 should check wich screensaver is *running*

People

Assignee:
Xfce Bug Triage
CC List:
10 users

Version

Version:
Unspecified

Attachments

add lightdm and light-locker support (718 bytes, patch)
2014-10-27 09:23 CET , Rob McCathie
no flags

Additional information