! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Editing XFCE keyboard settings requires unnecessary input
Status:
RESOLVED: MOVED
Product:
Xfce4-settings
Component:
Keyboard Settings

Comments

Description Yuv 2014-09-12 17:43:03 CEST
* Xubuntu 14.04 LTS amd64 installed from scratch.
* I want to edit a keyboard application shortcut.
To reproduce:
* Enter the Keyboard Settings, Application Shortcuts tab
* Select shortcut to edit
* Click Edit
* Click Open
* Browse to the command and select it
* click OK
Observed Result:
* A Command Shortcut window requires a click on the keyboard combination to proceed
Expected Result:
* Close the window and the change in Command takes effect (I do not want to change the Shortcut itself)
Workaround:
* Double-click on shortcut to edit (instead of selecting it and clicking the Edit button)
Comment 1 Simon Steinbeiss editbugs 2015-01-31 14:31:03 CET
This is the expected behavior, I'm not sure how this could be improved. How should the edit-button know what aspect you want to edit?

Double-clicking the corresponding column is not a workaround, it's a feature if you only want to modify one aspect.
Comment 2 Yuv 2015-01-31 15:15:50 CET
To make this behaviour more intuitive, add an OK button on the window to enter the Shortcut.  Pressing "OK" accepts the Command change while leaving the Shortcut unchanged.
Comment 3 Simon Steinbeiss editbugs 2015-01-31 15:28:40 CET
There already is an "OK" button in the window after the "open" dialog closes. (Note: you cannot add a custom button to the open dialog as it is part of Gtk2.)
Comment 4 Yuv 2015-01-31 15:33:26 CET
There is indeed an OK button on adding/editing the Command.  There is no OK button on adding/editing the Shortcut.  If I press a Shortcut, the window closes automatically (which is nice and time saving), but if I do not want to enter a Shortcut I want an option to click OK and leave the Shortcut unchanged while retaining the changed Command.  Right now the only thing I can do is either click Cancel (and lose the changes to the command) or press the Shortcut (which is unelegant because it forces me to remember what the Shortcut was in the first place).  An OK button on that last window would make it like the previous one, more intuitive.
Comment 5 Git Bot editbugs 2020-05-28 23:00:11 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-settings/-/issues/46.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #11157

Reported by:
Yuv
Reported on: 2014-09-12
Last modified on: 2020-05-28

People

Assignee:
Jérôme Guelfucci
CC List:
4 users

Version

Version:
unspecified

Attachments

Additional information