! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Switching calendar months causes GLib critical warnings.
Status:
RESOLVED: WONTFIX
Severity:
trivial

Comments

Description Steven Jackson 2014-09-07 19:35:09 CEST
Created attachment 5637 
Proposed fix

I see this warning when switching the month:

(orage:5198): GLib-CRITICAL **: Source ID 14 was not found when attempting to remove it

It's because upd_calendar has already completed so the timer source has already been destroyed implicitly. The stable GLib documentation says "It is a programmer error to attempt to remove a non-existent source."

I've attached a patch which checks that the source still exists before trying to remove it.
Comment 1 Steven Jackson 2014-09-07 19:39:57 CEST
Created attachment 5638 
Proposed fix

I screwed up the logic on the previous patch.
Comment 2 juha editbugs 2015-04-10 11:34:03 CEST
wierd that this is critical. In my opinion it should be just a warning.
Thanks for the report and fix!
Comment 3 Skunnyk editbugs 2019-10-27 18:39:37 CET
The orage project is not maintained anymore and has been archived. Closing bugs.

Bug #11146

Reported by:
Steven Jackson
Reported on: 2014-09-07
Last modified on: 2019-10-27

People

CC List:
0 users

Version

Attachments

Proposed fix (1.13 KB, patch)
2014-09-07 19:35 CEST , Steven Jackson
no flags
Proposed fix (1.13 KB, patch)
2014-09-07 19:39 CEST , Steven Jackson
no flags

Additional information