! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
LXDE power manager panel plugin does not build against LXPanel >= 0.7.0
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Guido Berhoerster 2014-08-25 23:38:10 CEST
The LXPanel plugin API was completely changed in version 0.7.0 and the power manager panel plugin does not build any more. The new API is described in http://wiki.lxde.org/en/How_to_write_plugins_for_LXPanel
Comment 1 Eric Koegel editbugs 2014-09-01 14:47:04 CEST
Yeah, it would be nice to still support the older plugin version for distros that won't be shipping 0.7.0 anytime soon.
There's a bounty on this bug report: https://www.bountysource.com/issues/4154619-lxde-power-manager-panel-plugin-does-not-build-against-lxpanel-0-7-0
Comment 2 Eric Koegel editbugs 2014-09-07 16:07:52 CEST
Created attachment 5635 
add support for lxpanel 0.7+

I wrote this patch because we're planning on a new stable version soon and we don't want xfpm to fail to compile. I obviously was hoping a patch would just show up :)
It keeps the code for the old lxde panel version and adds a little more to support the new version. Let me know if this fails to work for some reason.
Comment 3 Eric Koegel editbugs 2014-09-07 16:49:58 CEST
Created attachment 5636 
add support for lxpanel 0.7+

Posted too soon, the buildbot found a couple issues for me. This version should work as intended.
Comment 4 Guido Berhoerster 2014-09-08 09:45:21 CEST
(In reply to Eric Koegel from comment #3)
> Created attachment 5636 
> add support for lxpanel 0.7+
> 
> Posted too soon, the buildbot found a couple issues for me. This version
> should work as intended.

Thanks, just tested it and it builds and works fine.
Comment 5 Eric Koegel editbugs 2014-09-08 09:58:54 CEST
Thanks for testing, pushed to master:
commit 11d1b55b3d24581ae5e1a9721f6dcc4839788443
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Sun Sep 7 17:46:59 2014 +0300

    Add support for lxpanel 0.7+ (Bug 11108)
    
    The LXPanel plugin API was completely changed in version 0.7.0
    without any module versioning or backwards compatibility. This
    patch make the plugin work with the new version while retaining
    the ability to still build for the old version (based on checking
    the package version at compile time).
http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=11d1b55b3d24581ae5e1a9721f6dcc4839788443

Bug #11108

Reported by:
Guido Berhoerster
Reported on: 2014-08-25
Last modified on: 2014-09-08

People

Assignee:
Ali Abdallah
CC List:
1 user

Version

Version:
Unspecified

Attachments

add support for lxpanel 0.7+ (12.30 KB, patch)
2014-09-07 16:07 CEST , Eric Koegel
no flags
add support for lxpanel 0.7+ (12.41 KB, patch)
2014-09-07 16:49 CEST , Eric Koegel
no flags

Additional information