! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop 4.11.7 only allows to configure backdrop on first screen
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Landry Breuil editbugs 2014-08-23 11:05:53 CEST
Created attachment 5611 
screenshot of xfdesktop-settings

xfdesktop-settings only shows the dialog to configure the backdrop for DVI-0 screen, while xfce4-display-settings correctly shows DVI-0 and DVI-1 screens.
Comment 1 Eric Koegel editbugs 2014-08-23 19:39:29 CEST
  That impossibly hard to read infobar should say to move the dialog to the desktop/workspace you wish to configure. Does it update when you do that? If you're in Zaphod mode it might be easier to launch the settings app again on the 2nd screen.

  This was changed per the design SIG https://wiki.xfce.org/design/xfdesktop/settings and also because having tabs for the per-screen and per-worksapce and per-monitor combinations gets a bit messy.

Or is this a regression between one of the 4.11 releases?
Comment 2 Landry Breuil editbugs 2014-08-24 09:13:41 CEST
Hah, so rather a dark theme issue (xfce-dusk here), with a light theme i see the message.

When i move the dialog to DVI-1 it correctly updates the label in the dialog, but the selected backdrop is still the one from the previous display, dunno if it should update the selected backdrop to match the one in the currently focused display.

$xfconf-query -c xfce4-desktop -p /backdrop/screen0/monitorDVI-0/workspace0/last-image
/home/landry/wp/00061.jpg
$xfconf-query -c xfce4-desktop -p /backdrop/screen0/monitorDVI-1/workspace0/last-image 
/home/landry/wp/Degar_sunset_from_cannon_point.jpg


That's the first 4.11 release i'm testing. Is it possible to make the infobar display correctly with dark themes too, or the theme itself should be fixed?
Comment 3 Eric Koegel editbugs 2014-08-29 19:18:53 CEST
Yeah, at a minimum we need to hard code the label color since the infobar background color is hard coded.

We can also look at scrolling to/selecting the image when there's a monitor or workspace change.
Comment 4 Eric Koegel editbugs 2014-09-01 10:12:00 CEST
Created attachment 5621 
Hardcode the infobar label color

This should make the label readable with a dark theme.
Comment 5 Landry Breuil editbugs 2014-09-01 21:29:17 CEST
Comment on attachment 5621 
Hardcode the infobar label color

Yes, that's definitely nicer here with xfce-dusk theme.
Comment 6 Eric Koegel editbugs 2014-09-02 02:49:29 CEST
Thanks for testing, pushed to master:
commit b8b11ad4180f3b41dbb07bde88da1b1a6a1230ac
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Mon Sep 1 11:08:30 2014 +0300

    Hardcode the infobar label color (Bug 11100)
    
    The GtkInfoBar hard codes the background color which makes the
    label impossible to read with dark themes. This patch hard codes
    the label's color so you can read it with any theme.
http://git.xfce.org/xfce/xfdesktop/commit/?id=b8b11ad4180f3b41dbb07bde88da1b1a6a1230ac

Bug #11100

Reported by:
Landry Breuil
Reported on: 2014-08-23
Last modified on: 2014-09-02

People

Assignee:
Eric Koegel
CC List:
1 user

Version

Version:
Unspecified

Attachments

screenshot of xfdesktop-settings (146.01 KB, image/png)
2014-08-23 11:05 CEST , Landry Breuil
no flags
Hardcode the infobar label color (1.27 KB, patch)
2014-09-01 10:12 CEST , Eric Koegel
landry : review+

Additional information