! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Added display 'output' numerical/identifier prefix
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-settings
Component:
Display Settings

Comments

Description starlocke 2014-06-18 20:13:00 CEST
Created attachment 5528 
git format-patch --stdout HEAD^1 > ~/xfce4-display-settings-9ab0741.patch

On some systems (like as a VirtualBox guest), the display-settings
dialog needs better, discerning identifiers for displays.  It is
much easier to find a display when it is numbered than when all
displays share the same friendly name because they are all from
the same vendor.

This fix prefixes the 'output' number to the friendly-but-not-unique
names.  It should apply to 3 main UI elements:

- List of displays
- Dropdown for selecting display position
- Display identification "floater" boxes (when "Identify Displays"
  button is pressed).
Comment 1 starlocke 2014-06-18 20:16:32 CEST
One more thing... this xfce4-settings project cannot fully run "make" at this point in its commit history (commit #7dbe179 / 2014-06-17). I was able to get "xfce4-display-settings" compiled, and that was my good enough for me.

Here is a hint about what failed during "make":

Making all in xfsettingsd
make[2]: Entering directory `/home/victor/projects/xfce4-settings/xfsettingsd'
  CC       xfsettingsd-debug.o
debug.c: In function ‘xfsettings_dbg_print’:
debug.c:94:5: error: function might be possible candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
     string = g_strdup_vprintf (message, args);
     ^
cc1: all warnings being treated as errors
make[2]: *** [xfsettingsd-debug.o] Error 1
make[2]: Leaving directory `/home/victor/projects/xfce4-settings/xfsettingsd'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/victor/projects/xfce4-settings'
make: *** [all] Error 2
Comment 3 Simon Steinbeiss editbugs 2014-11-03 12:40:55 CET
Consequently marking this bug as fixed.

Bug #10964

Reported by:
starlocke
Reported on: 2014-06-18
Last modified on: 2014-11-03

People

Assignee:
Jérôme Guelfucci
CC List:
5 users

Version

Version:
unspecified

Attachments

Additional information