Comment 1 Landry Breuil 2014-06-12 22:52:21 CEST

Thanks for the patch, but i dont understand why you need #define N_(str) (str) in wi_common.c. Why not using the standard _() call ?

Also, for the /* translator */ hints comment, you dont need to add the braces around the if {} else {}, which renders the diff more complicated than it should be.

Other than that, good work! Expecting a fixed diff from you!

Comment 2 Landry Breuil 2014-11-23 21:44:24 CET

Mass-reassign all bugs from florian@ to goodies-dev@, thanks for the maintenance work! (and sorry for the bugmail spam..)

Created attachment 5793 
patch v2

> Why you need #define N_(str) (str)

I think it is appropriate and it is common practice:
http://www.gnu.org/software/gettext/manual/gettext.html#index-N_005f_002c-a-convenience-macro


> Why not using the standard _() call ?

wi_strerror() is const char *, and _() (gettext()) is char *

So it will lead to 4 warnings: "return makes pointer from integer without a cast [enabled by default]"

Patch is updated to v2 without braces for if else.

Comment 5 Landry Breuil 2014-12-04 17:58:47 CET

Thanks, applied in 4aedc49e