! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
update for upower 0.99 support
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Xfsettingsd

Comments

Description Eric Koegel editbugs 2014-05-29 17:45:50 CEST
Created attachment 5497 
Update for Upower 0.99

This patch adds a conditional check for a change upower 0.99 requires, obviously things will still work with upower 0.9.23 and before.
Comment 1 Jani Välimaa 2014-07-08 19:43:05 CEST
After applying this patch to xfce4-settings 4.11.2 (+ UPower 0.99.0) in Mageia Cauldron (latest development version), I see segfault at startup. Other users have also reported similar issues.

xfsettingsd[3380]: segfault at 0 ip b6de6bcd sp bffbd2d4 error 4 in libupower-glib.so.2.0.0[b6dd9000+25000]

I'm also seeing messages like this in .xsession-errors:

(xfsettingsd:3380): libupower-glib-WARNING **: Couldn't connect to proxy: Timeout was reached
Comment 2 Eric Koegel editbugs 2014-07-27 21:11:21 CEST
Hey,
  If it's crashing, can you get a backtrace with debug symbols? Maybe we can track it down that way.

  For the warnings you can try launching xfsettingsd with --g-fatal-warnings and it will crash on a warning, a backtrace of that would help us eliminate those runtime warnings too.
Comment 3 Jani Välimaa 2014-07-27 22:51:10 CEST
Created attachment 5566 
GDB backtrace

Here's the bactrace after attaching gdb to running xfsettingsd process after startup.
Comment 4 Jani Välimaa 2014-07-28 10:09:51 CEST
Applied patch from bug 11045 comment 1 to see if all this is somehow magically related to forking issue and seems it fixed the segfault.

I'll apply the patch also to Mageia xfce4-settings package and ask feedback from other users.
Comment 5 Samuli Suominen 2014-07-28 10:31:40 CEST
For what's it worth (not much :), I'll just say it:

This patch is in use at Gentoo's Portage ~arch (~arch equals to something like "testing" or "unstable")
And most Gentoo users use ~ərch, so most Gentoo Xfce users are using this patch, and we haven't received any bug reports about it
So far, all good
Comment 6 Eric Koegel editbugs 2014-07-28 11:00:21 CEST
Oh awesome! I was just waiting on my Mageia box to finish building to I could update it to Cauldron. I guess I'll hold off in hopes I accidentally fixed it :)
Comment 7 Jani Välimaa 2014-07-28 13:22:29 CEST
Affected users confirmed in downstream bug report [1] that after applying the patch from bug 11045 xfsettingsd doesn't segfault anymore with UPower 0.99 patch.

[1] https://bugs.mageia.org/show_bug.cgi?id=13602
Comment 8 Simon Steinbeiss editbugs 2014-07-28 17:59:26 CEST
Applied to master.

commit 4b89e20c97a3cf526aca831fe384f53db1c1691c
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Wed May 28 07:55:39 2014 +0300

    Add support for upower 0.99 (bug #10918)
    
    Amend the signal handler for the changing of display properties to work
    with upower 0.99.

Bug #10918

Reported by:
Eric Koegel
Reported on: 2014-05-29
Last modified on: 2014-07-28

People

Assignee:
Nick Schermer
CC List:
6 users

Version

Version:
unspecified

Attachments

Update for Upower 0.99 (2.52 KB, patch)
2014-05-29 17:45 CEST , Eric Koegel
no flags
GDB backtrace (24.16 KB, text/plain)
2014-07-27 22:51 CEST , Jani Välimaa
no flags

Additional information